-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: Migrate to defaulting to V2 instead of V1. #3459
Comments
Given the SDK behavior for invoking environment based connection and session is equivalent, I think swapping the behavior when opening via url from v1 to v2 is unlikely to create major issues (though obviously this would need to be tested). I agree that maintaining support for V1 in the medium term would be critical to allow migration, and I suspect the V1 sdk will be in maintenance mode and in public use for a good long while, so it could still be supported by re-namespacing those provider specific constructors (i.e. This would be a breaking change as it renames a public function, but will cause explicit notice when people update. The major issue will be where implementation has logic for both, excising it later could become time consuming, though again, V1 SDK support will probably be maintained for a while. |
I don't think that's necessary, we can just leave them as-is. There's no need to make a breaking change. At such time when we remove support for V1 (which will be a breaking change), we can alias the non-versioned functions like |
I've marked the V1 functions deprecated, and changed the default for URLs to V2. When I create the next release, I'll call out the breaking change for URLs, and announce a plan to remove the support for V1 in in 6 months, and ask for feedback on the latter (we might have to keep support for longer). |
We currently support both in most packages. URL openers default to V1.
We should announce that we're going to change the default for URLOpeners, then wait 1-2 release or say 6 months before making the change.
We should also consider dropping support for AWSv1 entirely, but I'm hesitant to do that too proactively. I don't have any visibility into whether Go CDK users use it or not.
The text was updated successfully, but these errors were encountered: