Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update firebase/php-jwt to 4.0 #1063

Closed
wants to merge 2 commits into from
Closed

Conversation

ashbeats
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 27, 2016
@ashbeats
Copy link
Author

ok. it's signed.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 27, 2016
@bshaffer
Copy link
Contributor

Is there a specific reason you need Firebase 4.0?

@boredom2
Copy link

I need it:-)
The Microsoft Azure SDK has been updated and is only compatible with JWT 4.0 now.
So its really complicated to include Google and Azure with different dependencies for this Lib.

@ashbeats
Copy link
Author

I'm using laravel/spark, which requires firebase v4.0.

@shakaran shakaran mentioned this pull request Oct 1, 2016
@tomschlick
Copy link

Another request for this from another laravel/spark user. Can't upgrade spark without it.

Doesn't look like there are any breaking changes in the 3.0->4.0 migration so are there any reasons not to upgrade?

@etremblay
Copy link

This PR would be very appreciated !

@bshaffer
Copy link
Contributor

This change will not have an affect as long as google/auth requires ~3.0. This change should fix that: googleapis/google-auth-library-php#137. I will merge this as soon as this is tagged and updated

@tomschlick
Copy link

Any update? googleapis/google-auth-library-php#137 has been merged.

@bshaffer
Copy link
Contributor

bshaffer commented Nov 2, 2016

This was merged into master in #1082

@bshaffer bshaffer closed this Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants