Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getters for UserCredentials member variables #52

Closed
ajkannan opened this issue Dec 1, 2015 · 3 comments
Closed

Getters for UserCredentials member variables #52

ajkannan opened this issue Dec 1, 2015 · 3 comments
Assignees
@pongad
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@ajkannan
Copy link

ajkannan commented Dec 1, 2015

Is there a reason that UserCredentials' member variables don't have public getters? It would be useful to have getters like in ServiceAccountCredentials.
@ajkannan ajkannan mentioned this issue Dec 1, 2015
Closed
@anthmgoogle
Copy link
Contributor

No reason not to add them. These should be added.

@pongad pongad self-assigned this Dec 2, 2015
@ajkannan
Copy link
Author

Thanks for adding this! Is there a chance we can get an artifact pushed to maven with this change?

@pongad
Copy link
Contributor

pongad commented Apr 29, 2016

This is already included in v0.4.0. So I'm closing this

@pongad pongad closed this as completed Apr 29, 2016
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pongad pongad

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pongad @ajkannan @anthmgoogle @yoshi-automation