Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid loading fast-text-encoding if not in browser environment #627

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

modeswitch
Copy link
Contributor

@modeswitch modeswitch commented Feb 13, 2019

Fixes #626

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@JustinBeckwith JustinBeckwith changed the title Avoid loading fast-text-encoding if not in browser environment fix: avoid loading fast-text-encoding if not in browser environment Feb 13, 2019
@JustinBeckwith
Copy link
Contributor

Thanks for the fix!

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #627 into master will decrease coverage by 0.22%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   88.47%   88.25%   -0.23%     
==========================================
  Files          18       18              
  Lines         781      783       +2     
  Branches       85       86       +1     
==========================================
  Hits          691      691              
- Misses         79       80       +1     
- Partials       11       12       +1
Impacted Files Coverage Δ
src/crypto/browser/crypto.ts 11.53% <50%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aded4f5...f5821a3. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #627 into master will decrease coverage by 0.22%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
- Coverage   88.47%   88.25%   -0.23%     
==========================================
  Files          18       18              
  Lines         781      783       +2     
  Branches       85       86       +1     
==========================================
  Hits          691      691              
- Misses         79       80       +1     
- Partials       11       12       +1
Impacted Files Coverage Δ
src/crypto/browser/crypto.ts 11.53% <50%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78f164...ef6f894. Read the comment docs.

@modeswitch
Copy link
Contributor Author

@JustinBeckwith I see where the coverage dropped, but I'm not sure how to simulate a browser environment without a bunch of extra work. For one line of code that seems excessive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants