-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid loading fast-text-encoding if not in browser environment #627
fix: avoid loading fast-text-encoding if not in browser environment #627
Conversation
Thanks for the fix! |
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 88.47% 88.25% -0.23%
==========================================
Files 18 18
Lines 781 783 +2
Branches 85 86 +1
==========================================
Hits 691 691
- Misses 79 80 +1
- Partials 11 12 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
- Coverage 88.47% 88.25% -0.23%
==========================================
Files 18 18
Lines 781 783 +2
Branches 85 86 +1
==========================================
Hits 691 691
- Misses 79 80 +1
- Partials 11 12 +1
Continue to review full report at Codecov.
|
@JustinBeckwith I see where the coverage dropped, but I'm not sure how to simulate a browser environment without a bunch of extra work. For one line of code that seems excessive? |
Fixes #626