Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gson Proguard Config #1155

Closed
naturalwarren opened this issue Sep 13, 2017 · 2 comments
Closed

Gson Proguard Config #1155

naturalwarren opened this issue Sep 13, 2017 · 2 comments
Labels
proguard-r8 Issues relating to the use of ProGuard and/or R8, such as problems due to obfuscation

Comments

@naturalwarren
Copy link
Contributor

naturalwarren commented Sep 13, 2017

The sample proguard config specifies to keep sun.misc. This seems really strange since that package ships with the runtime.

-keep class sun.misc.Unsafe { *; }

Should we update the proguard config to use don't warn? This seems to the precedent:

RxJava: ReactiveX/RxJava#1415
PlayServices: krschultz/android-proguard-snippets#116

@JakeWharton
Copy link
Contributor

The 'android-proguard-snippets' repo is a tragedy of the commons and should never be used to justify correct rules.

But yeah, this should be -dontwarn. Want to PR?

@naturalwarren
Copy link
Contributor Author

Will do, thanks Jake.

@Marcono1234 Marcono1234 added the proguard-r8 Issues relating to the use of ProGuard and/or R8, such as problems due to obfuscation label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proguard-r8 Issues relating to the use of ProGuard and/or R8, such as problems due to obfuscation
Projects
None yet
Development

No branches or pull requests

3 participants