Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload chunk fetchers create background tasks even with background sessions #184

Open
mwyman opened this issue Jan 31, 2020 · 0 comments
Open

Comments

@mwyman
Copy link
Contributor

mwyman commented Jan 31, 2020

The chunk fetchers using a background session still create background task identifiers. Because the upload is moved out of process, when the app is backgrounded the task identifier may not be released before the app runs out of time.

When GTMSessionUploadFetcher has .useBackgroundSessions=YES, GTMSessionFetcher .useBackgroundSession is not being set on chunk fetchers explicitly but being implied due to having a session identifier (sets .usingBackgroundSession=YES).

The test for whether to create a background task identifier only checks .useBackgroundSession. Should check .usingBackgroundSession instead.

@mwyman mwyman self-assigned this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant