Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests #287

Closed
vitkarpov opened this issue Mar 2, 2019 · 2 comments
Closed

e2e tests #287

vitkarpov opened this issue Mar 2, 2019 · 2 comments

Comments

@vitkarpov
Copy link
Contributor

Ladies and gentleman! 👋 🍷

While doing #285, I noticed that there are no e2e tests. I mean, surely we have tests for init with different configs but it'd be robust to have full e2e tests (call CLI using execa and assert output, filesystem and so on), right?

In my case, I checked that yarn is used if there's yarn.lock indeed only manually (there's a unit test though but anyway).

What do you think if someone (me) brings those kind of tests here?
@ofrobots
Copy link
Contributor

ofrobots commented Mar 7, 2019

Hi @vitkarpov. test-kitchen.ts is supposed to be the end-to-end test. It is not as extensive as one could want, but it is there. It would be awesome if you want to expand the e2e tests here ❤.

@vitkarpov
Copy link
Contributor Author

test-kitchen.ts is supposed to be the end-to-end test.

Ah, I see that now, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofrobots @vitkarpov