Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Set no-floating-promises to error #793

Closed
danielbankhead opened this issue Sep 11, 2023 · 4 comments · Fixed by #901
Closed

feat!: Set no-floating-promises to error #793

danielbankhead opened this issue Sep 11, 2023 · 4 comments · Fixed by #901
Labels
semver: major type: feature request

Comments

@danielbankhead
Copy link
Collaborator

danielbankhead commented Sep 11, 2023 •
edited
Loading

Un-revert #808 and set no-floating-promises to error

Context:

Dependency:
This was referenced Oct 4, 2023
Merged
Merged
@naseemkullah
Copy link
Contributor

hey @danielbankhead can we move forward with this now? I can make a PR if so, thank you!

@danielbankhead
Copy link
Collaborator Author

@naseemkullah feel free to create a PR, however it will take some time before we do another major release

@tonycoco
Copy link
Contributor

tonycoco commented Apr 3, 2024

Working on another major release with some changes to drop Node 14/16 soon. Anyone want to create a PR I can help merge.

@danielbankhead
Copy link
Collaborator Author

@tonycoco We cannot drop Node 14/16 without a proposal to update all googleapis Node.js client libraries. We're planning to get to this sometime this semester.

@danielbankhead danielbankhead mentioned this issue Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver: major type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Set no-floating-promises to error google/gts
3 participants
@tonycoco @danielbankhead @naseemkullah