Address a few more Error Prone warnings.

RELNOTES=n/a
PiperOrigin-RevId: 745214427

Author: cpovirk

android/guava/src/com/google/common/collect/FluentIterable.java

@@ -844,13 +844,4 @@ public final String join(Joiner joiner) {
   public final E get(int position) {
     return Iterables.get(getDelegate(), position);
   }
-
-  /** Function that transforms {@code Iterable<E>} into a fluent iterable. */
-  private static class FromIterableFunction<E extends @Nullable Object>
-      implements Function<Iterable<E>, FluentIterable<E>> {
-    @Override
-    public FluentIterable<E> apply(Iterable<E> fromObject) {
-      return FluentIterable.from(fromObject);
-    }
-  }
 }

android/guava/src/com/google/common/collect/Tables.java

@@ -476,14 +476,13 @@ public Map<R, V2> column(@ParametricNullness C columnKey) {
       return Maps.transformValues(fromTable.column(columnKey), function);
     }
 
-    Function<Cell<R, C, V1>, Cell<R, C, V2>> cellFunction() {
-      return cell ->
-          immutableCell(cell.getRowKey(), cell.getColumnKey(), function.apply(cell.getValue()));
+    Cell<R, C, V2> applyToValue(Cell<R, C, V1> cell) {
+      return immutableCell(cell.getRowKey(), cell.getColumnKey(), function.apply(cell.getValue()));
     }
 
     @Override
     Iterator<Cell<R, C, V2>> cellIterator() {
-      return Iterators.transform(fromTable.cellSet().iterator(), cellFunction());
+      return Iterators.transform(fromTable.cellSet().iterator(), this::applyToValue);
     }
 
     @Override

android/guava/src/com/google/common/eventbus/Dispatcher.java

@@ -76,6 +76,7 @@ private static final class PerThreadQueuedDispatcher extends Dispatcher {
     // This dispatcher matches the original dispatch behavior of EventBus.
 
     /** Per-thread queue of events to dispatch. */
+    @SuppressWarnings("ThreadLocalUsage") // Each Dispatcher needs its own state.
     private final ThreadLocal<Queue<Event>> queue =
         new ThreadLocal<Queue<Event>>() {
           @Override
@@ -85,6 +86,7 @@ protected Queue<Event> initialValue() {
         };
 
     /** Per-thread dispatch state, used to avoid reentrant event dispatching. */
+    @SuppressWarnings("ThreadLocalUsage") // Each Dispatcher needs its own state.
     private final ThreadLocal<Boolean> dispatching =
         new ThreadLocal<Boolean>() {
           @Override

android/guava/src/com/google/common/util/concurrent/ListenerCallQueue.java

@@ -39,7 +39,7 @@
  * <ul>
  *   <li>Multiple events for the same listener are never dispatched concurrently.
  *   <li>Events for the different listeners are dispatched concurrently.
- *   <li>All events for a given listener dispatch on the provided {@link #executor}.
+ *   <li>All events for a given listener dispatch on the provided executor.
  *   <li>It is easy for the user to ensure that listeners are never invoked while holding locks.
  * </ul>
  *

guava/src/com/google/common/collect/FluentIterable.java

@@ -849,13 +849,4 @@ public final E get(int position) {
   public final Stream<E> stream() {
     return Streams.stream(getDelegate());
   }
-
-  /** Function that transforms {@code Iterable<E>} into a fluent iterable. */
-  private static class FromIterableFunction<E extends @Nullable Object>
-      implements Function<Iterable<E>, FluentIterable<E>> {
-    @Override
-    public FluentIterable<E> apply(Iterable<E> fromObject) {
-      return FluentIterable.from(fromObject);
-    }
-  }
 }

guava/src/com/google/common/collect/Tables.java

@@ -478,19 +478,18 @@ public Map<R, V2> column(@ParametricNullness C columnKey) {
       return Maps.transformValues(fromTable.column(columnKey), function);
     }
 
-    Function<Cell<R, C, V1>, Cell<R, C, V2>> cellFunction() {
-      return cell ->
-          immutableCell(cell.getRowKey(), cell.getColumnKey(), function.apply(cell.getValue()));
+    Cell<R, C, V2> applyToValue(Cell<R, C, V1> cell) {
+      return immutableCell(cell.getRowKey(), cell.getColumnKey(), function.apply(cell.getValue()));
     }
 
     @Override
     Iterator<Cell<R, C, V2>> cellIterator() {
-      return Iterators.transform(fromTable.cellSet().iterator(), cellFunction());
+      return Iterators.transform(fromTable.cellSet().iterator(), this::applyToValue);
     }
 
     @Override
     Spliterator<Cell<R, C, V2>> cellSpliterator() {
-      return CollectSpliterators.map(fromTable.cellSet().spliterator(), cellFunction());
+      return CollectSpliterators.map(fromTable.cellSet().spliterator(), this::applyToValue);
     }
 
     @Override

guava/src/com/google/common/eventbus/Dispatcher.java

@@ -76,6 +76,7 @@ private static final class PerThreadQueuedDispatcher extends Dispatcher {
     // This dispatcher matches the original dispatch behavior of EventBus.
 
     /** Per-thread queue of events to dispatch. */
+    @SuppressWarnings("ThreadLocalUsage") // Each Dispatcher needs its own state.
     private final ThreadLocal<Queue<Event>> queue =
         new ThreadLocal<Queue<Event>>() {
           @Override
@@ -85,6 +86,7 @@ protected Queue<Event> initialValue() {
         };
 
     /** Per-thread dispatch state, used to avoid reentrant event dispatching. */
+    @SuppressWarnings("ThreadLocalUsage") // Each Dispatcher needs its own state.
     private final ThreadLocal<Boolean> dispatching =
         new ThreadLocal<Boolean>() {
           @Override

guava/src/com/google/common/util/concurrent/ListenerCallQueue.java

@@ -39,7 +39,7 @@
  * <ul>
  *   <li>Multiple events for the same listener are never dispatched concurrently.
  *   <li>Events for the different listeners are dispatched concurrently.
- *   <li>All events for a given listener dispatch on the provided {@link #executor}.
+ *   <li>All events for a given listener dispatch on the provided executor.
  *   <li>It is easy for the user to ensure that listeners are never invoked while holding locks.
  * </ul>
  *