Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose and/or matchers #1177

Closed
kashike opened this issue Apr 12, 2018 · 4 comments
Closed

Expose and/or matchers #1177

kashike opened this issue Apr 12, 2018 · 4 comments

Comments

@kashike
Copy link
Contributor

kashike commented Apr 12, 2018

The and and or matcher implementations are restricted to use by AbstractMatcher, unlike the not (and other matchers in this class) matcher - would it be possible to expose these as Matchers.and(a, b) and Matchers.or(a, b)? This would allow use of these matchers without extending AbstractMatcher for the default implementation, or creating your own matchers.

@cterse
Copy link

cterse commented May 24, 2021

Its been quite long since this issue was opened. Can I look into this?

@kashike
Copy link
Contributor Author

kashike commented May 25, 2021

@cterse see #1200

@kashike
Copy link
Contributor Author

kashike commented Apr 29, 2023

The and and or methods in Matcher could be default implemented now that Guice requires Java 8 - is this something that might be considered now, or is this a dead idea?

@sameb
Copy link
Member

sameb commented Apr 29, 2023

Yeah, that sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants