Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace javax.inject with jakarta.inject #1463

Closed
cowwoc opened this issue Dec 7, 2020 · 2 comments
Closed

Replace javax.inject with jakarta.inject #1463

cowwoc opened this issue Dec 7, 2020 · 2 comments

Comments

@cowwoc
Copy link

cowwoc commented Dec 7, 2020

Please replace Guide's dependency from javax.inject to jakarta.inject. See google/dagger#2058 for a related discussion.

By the looks of it, the package name remains the same so this is a drop-in replacement. The reason you want to make this change is anyone depending on guice is currently forced to add this to Maven:

<exclusions>
	<exclusion>
		<groupId>javax.inject</groupId>
		<artifactId>javax.inject</artifactId>
	</exclusion>
</exclusions>

to avoid getting the following error at boot time:

java.lang.module.ResolutionException: Modules jakarta.inject and javax.inject export package javax.inject to module org.flywaydb.core'.

@cogman
Copy link

cogman commented Dec 12, 2020

Note, I submitted issue #1383 to Guice at the same time as the dagger issue.

@cowwoc
Copy link
Author

cowwoc commented Dec 13, 2020

Closed in favor of #1383.

@cowwoc cowwoc closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants