TypeWithAttrTypeConverter doesn't handle blocks args from loops

[asraa]

If a loop has loop carrying variables that are secret, then the inner type conversion to a ciphertext needs to happen. The secret-to-scheme passes rely on TypeWithAttrTypeConverter - but this code doesn't handle that case:

heir/lib/Utils/ConversionUtils.cpp

Line 297 in ad59e8f

Attribute TypeWithAttrTypeConverter::getValueAttr(Value value) const {

In addition, affine for loops are converted in secret-to-scheme with a generic ConvertAny pass that intends to convert operands and regions. But that code relies on the base TypeConverter, so it doesn't actually convert secret types (see SecretToCKKSTypeConverter's conversion callbacks):

heir/lib/Utils/ConversionUtils.cpp

Lines 40 to 72 in ad59e8f

	LogicalResult convertAnyOperand(const TypeConverter *typeConverter,
	Operation *op, ArrayRef<Value> operands,
	ConversionPatternRewriter &rewriter) {
	if (typeConverter->isLegal(op)) {
	return failure();
	}
	SmallVector<Type> newOperandTypes;
	if (failed(
	typeConverter->convertTypes(op->getOperandTypes(), newOperandTypes)))
	return failure();
	SmallVector<Type> newResultTypes;
	if (failed(typeConverter->convertTypes(op->getResultTypes(), newResultTypes)))
	return failure();
	SmallVector<std::unique_ptr<Region>, 1> regions;
	IRMapping mapping;
	for (auto &r : op->getRegions()) {
	Region *newRegion = new Region(op);
	rewriter.cloneRegionBefore(r, *newRegion, newRegion->end(), mapping);
	if (failed(rewriter.convertRegionTypes(newRegion, *typeConverter)))
	return failure();
	regions.emplace_back(newRegion);
	}
	Operation *newOp = rewriter.create(OperationState(
	op->getLoc(), op->getName().getStringRef(), operands, newResultTypes,
	op->getAttrs(), op->getSuccessors(), regions));
	rewriter.replaceOp(op, newOp);
	return success();
	}

Here's a reproducer:

module {
  func.func @test(%arg0: !secret.secret<tensor<1x1024xf32>> {mgmt.mgmt = #mgmt.mgmt<level = 1>}) -> !secret.secret<tensor<1x1024xf32>> attributes {llvm.emit_c_interface} {
    %c1 = arith.constant 1 : index
    %2 = affine.for %arg1 = 1 to 1024 iter_args(%arg2 = %arg0) -> (!secret.secret<tensor<1x1024xf32>>) {
      %4 = secret.generic ins(%arg2 : !secret.secret<tensor<1x1024xf32>>) attrs = {mgmt.mgmt = #mgmt.mgmt<level = 1>} {
      ^body(%input0: tensor<1x1024xf32>):
        %7 = tensor_ext.rotate %input0, %c1 : tensor<1x1024xf32>, index
        secret.yield %7 : tensor<1x1024xf32>
      } -> !secret.secret<tensor<1x1024xf32>>
      affine.yield %4 : !secret.secret<tensor<1x1024xf32>>
    } {mgmt.mgmt = #mgmt.mgmt<level = 1>}
    %3 = secret.generic ins(%2 : !secret.secret<tensor<1x1024xf32>>) attrs = {mgmt.mgmt = #mgmt.mgmt<level = 0>} {
    ^body(%input0: tensor<1x1024xf32>):
      %4 = mgmt.modreduce %input0 : tensor<1x1024xf32>
      secret.yield %4 : tensor<1x1024xf32>
    } -> !secret.secret<tensor<1x1024xf32>>
    return %3 : !secret.secret<tensor<1x1024xf32>>
  }
}

Fix incoming.