Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip scalars when broadcasting for batch dimension agreement #6145

Merged
merged 1 commit into from
Mar 20, 2021
Merged

skip scalars when broadcasting for batch dimension agreement #6145

merged 1 commit into from
Mar 20, 2021

Conversation

froystig
Copy link
Member

fixes #6096

@froystig froystig added the pull ready Ready for copybara import and testing label Mar 20, 2021
@froystig froystig requested a review from mattjj March 20, 2021 04:09
@froystig froystig self-assigned this Mar 20, 2021
@google-cla google-cla bot added the cla: yes label Mar 20, 2021
mattjj
mattjj approved these changes Mar 20, 2021
View reviewed changes
Copy link
Collaborator

@mattjj mattjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood catch! And +1 to reverting naryop back to binary, and just special-casing regularized_incomplete_beta.

@copybara-service copybara-service bot merged commit a29d07f into master Mar 20, 2021
@sharadmv
Copy link
Collaborator

Does this also fix #3813?

@froystig froystig mentioned this pull request Mar 22, 2021
Closed
@mattjj mattjj deleted the issue6096 branch March 24, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjj mattjj mattjj approved these changes

Assignees

@froystig froystig

Labels
cla: yes pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

betainc batching rule is not quite correct
3 participants
@froystig @sharadmv @mattjj