Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds example project using jib-maven-plugin. #62

Merged
merged 7 commits into from
Feb 7, 2018
Merged

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Feb 6, 2018

Fixes #61

This project builds a simple HelloWorld application that uses one resource file and one dependency.

@coollog coollog requested a review from loosebazooka February 6, 2018 20:04
@coollog
Copy link
Contributor Author

coollog commented Feb 6, 2018

@mattmoor This may be handy as an example to play around with.


package example;

import com.google.common.io.Resources;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For examples like this it's good if we can keep dependencies to an absolute minimum, not even Guava.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example was intended to show how Jib can pack dependencies, resources, and classes into separate layers and that running the final image runs the application accordingly. I included Guava as an example dependency. Should I remove it and leave it as just a class and a resource instead?

@coollog coollog added this to the 0.1.1 milestone Feb 7, 2018
@coollog coollog merged commit c8a849a into master Feb 7, 2018
@coollog coollog deleted the example-project branch February 8, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants