Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in \mathopen #187

Closed
jonbarron opened this issue Oct 25, 2023 · 3 comments
Closed

Typo in \mathopen #187

jonbarron opened this issue Oct 25, 2023 · 3 comments
Labels
bug: major

Comments

@jonbarron
Copy link
Contributor

It looks like abs() is broken because \mathopen is misspelled there. Am I understanding this correctly?

latexify_py/src/latexify/codegen/expression_rules.py

Line 218 in e0ddde4

"abs": FunctionRule(r"\mathropen{}\left|", r"\mathclose{}\right|", is_wrapped=True),

@odashi
Copy link
Collaborator

odashi commented Oct 25, 2023

Thanks for reporting the bug. Could you propose a pull request so that I can simply merge the changes to fix it?

@jonbarron
Copy link
Contributor Author

Hah sadly no, I don't really know how to use github!

@jonbarron
Copy link
Contributor Author

okay I might have submitted a PR for review, I'm bad enough at github that I don't know if I did it right. #188

@odashi odashi mentioned this issue Oct 26, 2023
Merged
@odashi odashi closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonbarron @odashi