Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow configuration of layout--fixed-drawer breakpoint #1317

Closed
dryror opened this issue Aug 5, 2015 · 3 comments
Closed

Comments

@dryror
Copy link

dryror commented Aug 5, 2015

Currently the layout--fixed-drawer breakpoint is hard coded at 1024px. While this is better than the previous 850px, it is still too narrow for certain applications.

It would be nice to able to set this without having to go into the MDL code to change it.

Currently the sass variable $layout-screen-size-threshold doesn't have the !default modifier to allow it to be modified.

The breakpoint is also set in the layout.js file under MaterialLayout.prototype.Constant_.MAX_WIDTH. While it is possible to override this without touching the MDL code, it feels a bit hacky.

Adding the !default modifier to the sass variable and documenting that the js variable has to be changed as well could be a easy way to allow this option.

Just for reference, the Material Design website uses a breakpoint of 1479px for the fixed nav drawer.

@surma
Copy link
Contributor

surma commented Aug 5, 2015

Layout needs to be brought in line in general with the adaptive UI break points. Thanks for the issue :)

@surma surma added this to the V1.1 milestone Aug 5, 2015
@patrick-jones
Copy link

I want to chime in that this should definitely be configurable, not just raised from 1024. The spec doesn't mandate that everyone makes the drawer permanent at a specific width -- it recommends it as the default for desktop. Elsewhere, the spec emphasizes that "your app's structure should be influenced by the content and tasks you want to show your users". For some content-focused apps, a permanent drawer would be an unwelcome waste of space.

@surma surma modified the milestones: V1.1, V2 Jan 14, 2016
@traviskaufman
Copy link
Contributor

closing; superseded by #4476 . Because the drawer will be broken out of an overarching "layout" component, it will no longer make assumptions about when it should be fixed vs. not.

We are still in the very early stages of v2 and are currently working towards an alpha. Our master branch is where all v2 work is happening if you are interested in keeping up with its progress. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants