Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ml-collections breaks on Python 3.12 by relying on removed imp module #30

Closed
hylkedonker opened this issue May 28, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@hylkedonker
Copy link

Describe the bug
This package no longer works on Python 3.12, because it relies on the imp module which has been removed in Python 3.12.

To Reproduce

from ml_collections import config_flags

which gives the error message:

Traceback (most recent call last):
File "", line 1, in
File "/home/user/.local/lib/python3.12/site-packages/ml_collections/config_flags/init.py", line 17, in
from .config_flags import DEFINE_config_dataclass
File "/home/user/.local/lib/python3.12/site-packages/ml_collections/config_flags/config_flags.py", line 23, in
import imp
ModuleNotFoundError: No module named 'imp'

Environment:

  • OS Version: Ubuntu 24.04 LTS
  • Python: 3.12
@hylkedonker hylkedonker added the bug Something isn't working label May 28, 2024
@hylkedonker
Copy link
Author

I just came across this PR, which aims to fix the problem:
#28

@hylkedonker
Copy link
Author

A duplicate of #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant