-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model Viewer crashing Google Chrome on some devices #1043
Comments
@aviggiano thanks for reporting this issue! I have not reproduced that issue yet, but from a visual inspection that sure does look like a bad crash. It looks like the whole tab is crashing and recovering 😳 If I were to speculate, I would say it is likely that the WebGL context is being lost as part of the crash. We do dispatch an <!-- Somewhere on the page: -->
<model-viewer id="modelViewer" ...></model-viewer>
<!-- Later on: -->
<script>
modelViewer.addEventListener('error', (event) => {
const {type} = event.detail;
if (type === 'webglcontextlost') {
// WebGL crashed, do something to recover!
}
});
</script> |
@aviggiano You mentioned that you have not been able to reproduce the bug. How did you collect that recording of the bug? |
@cdata our client's user recorded their screen, but using our own devices we can't reproduce it. |
@aviggiano thanks! Do you happen to have any more specific details about the client's user's device? Windows version, any hardware details, etc? |
@aviggiano also, if possible, it would be really helpful to get the reporting user to do this:
The report looks like this (taken from my own laptop):
|
Ping @aviggiano if you aren't able to get |
@cdata I'm scheduling a face-to-face meeting with the user that experienced the bug to get the report from them. Are there any other tests that might be useful to diagnose this issue? |
I think chrome://gpu will be comprehensive enough for us. It will tell us what we need to know about the hardware of the device in question. Ultimately what we need to be able to do is have a comparable hardware device to try to reproduce the crash on. Otherwise, we can only speculate about what is causing the problem. |
@cdata sorry for the late reply, here's the report from two devices that had this issue: In addition, we performed a couple more tests that may help you diagnose this issue:
Please let me know if we can do anything to help solve this problem. |
In the past, I've been able to address this on machines with older graphics cards by turning off Chrome hardware acceleration. (Settings >System >Advanced >System >Use hardware acceleration when available). Beware, this has potential to affect Chrome performance though. |
@aviggiano This looks like a GPU driver bug of some kind. Interestingly, both of those cases report a Windows version almost two years out of date: Win10 April 2018 update. It's entirely possible Windows has fixed this in the meanwhile. I know it's a lot to ask, but could you suggest your user perform an OS update and see if that fixes the problem? I won't be able to do much on my side until I find a physical machine I can repro on. |
@elalish Thank you for the response. Indeed since we are not in direct contact with them (they are e-commerce users from our client), I'm not sure if we'll be able to ask them to update their OS. I'm already happy that we managed to get the GPU report 😆 Anyway, this will only help us diagnose this issue, but it will still happen to other people. Thanks |
@aviggiano Yeah, I kind of figured as much. Thanks again for the GPU reports. Device compatibility is tricky; if it was just a missing GL extension we could check ahead of time, but this is just a bug. If we got enough data to figure out the scope of where it occurs, you could screen it with At least your can listen for our |
Description
We have implemented the Model Viewer on an e-commerce's website and some users (2 out of 10) are experiencing a weird bug where the browser seems to crash (black screen) and recover after a short while. The model does not appear after downloading, but we can see only the "drag to rotate" icon indicating that the 3D should've been there.
I am not sure how to reproduce it, since our QA have tested the same URL on multiple devices (using browserstack and crossbrowsertesting) and none of them had this problem.
Live Demo
Browser Affected
OS
Versions
The text was updated successfully, but these errors were encountered: