Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely slow performance with specific test file #2958

Closed
hybridherbst opened this issue Nov 4, 2021 · 3 comments · Fixed by #3004
Closed

Extremely slow performance with specific test file #2958

hybridherbst opened this issue Nov 4, 2021 · 3 comments · Fixed by #3004
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue

Comments

@hybridherbst
Copy link
Contributor

Description

The entire browser locks up when loading the comparatively small attached file.
This seems to be a threejs issue as it also happens in threejs editor and not only in model-viewer, tracked here for awareness.

See mrdoob/three.js#22785 for full description and test file.

Might be related to the recent slowdowns mentioned in #2915 regarding shader compilation - the attached file will probably cause a number of different shaders to compile.

@ghost
Copy link

ghost commented Nov 5, 2021

This sounds like the threejs slowdown issue currently tracked by 2915.

Which browser are you testing on?

As a workaround you can pin v1.8 until our next release comes, e.g. <script type="module" src="https://unpkg.com/@google/model-viewer@1.8.0/dist/model-viewer.min.js"></script>

@hybridherbst
Copy link
Contributor Author

It's Chrome on Windows, in the threejs issue a couple of related problems are linked - seems my poor little test file runs into multiple bugs in Chrome and threejs that together make it load forever.

@ghost
Copy link

ghost commented Nov 10, 2021

Yes Windows is one of the main offenders, Chrome on OSX seems to be ok. Our only solution/workaround at the moment is to pin an older version model-viewer (which uses previous threejs) while this gets cleared up.

@samaneh-kazemi samaneh-kazemi added the flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: not model-viewer Problems that are related to our project but are ultimately some other project's issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants