-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't add library using SPM #1916
Comments
Our SPM package is not versioned. You can either check out main branch or a commit hash |
I have now tried to check out the main branch and commit 504ab8a without success. I get the following error: My project is using Firebase as well, that also includes abseil. |
Hmm I'm guessing it's because we are using a fork of the abseil that firebase is using. Do you mind sharing which packages specifically you are using so I can try and reproduce the issue? |
|
I didn't have any issues adding Firebase to the project. Maybe first add Firebase and then the nearby library. |
Any update on fixing this issue? Still unable to add the library via SPM whether using the |
@bourdakos1 at Monzo we're trying to migrate from the Nearby Messages SDK to this new one and we're hitting the
Looks like it could be an issue with how the package is defined. Maybe it needs to have a transitive dependency on Firebase and/or abseil |
This may be tricky to resolve. I tried aliasing our C++17 fork of abseil and it fixed the I'll try building using If that doesn't work, we could try doing a binary distribution of Nearby Connections. |
So, any update on this then? @bourdakos1 |
I was able to make a bit of progress this weekend. Dynamic linking one of the libraries resolved the duplicate symbol linker errors I was seeing, which was the biggest blocker. However, any shared dependencies still need to have unique product names and unique repo names. SPM doesn't disambiguate with repos with org names so As of a few days ago, Firebase updated it's gRPC dependency in a way that it now conflicts with Nearby's use of Going forward, to avoid conflicts with Firebase, I think we'll need to:
Alternatively, we could discuss with Firebase on a product name scheme that causes less collisions with source vs binary builds. In theory, postfixing binary products with something like |
@jose-pay @ugommirikwe @championofblocks Can you try using:
And use the If that works, I'll submit #2386 |
Closing, feel free to re-open if the issue persists. |
I'm running into a similar (the same?) issue when trying to add both the latest version of the firebase ios sdk (11.6.0) and the latest nearby main branch using SPM... Removing Firebase allows me to add Nearby, and similarly I can add Firebase and not Nearby without any problems. But having them both together causes issues with FirebaseCore not resolving. I've tried with the both the |
@spectrl are you able to provide any logs? |
It's very easy to reproduce in a new project. Just add Firebase via SPM, and then try to add Nearby via SPM (which will fail to resolve). |
Thanks, I’ll take a look. Do you mind filing an issue with firebase as well, if you haven’t done so already? |
Project
Nearby Connections
Language
Swift
OS Platform
Windows
What happened?
Followed instructions from this page:
https://github.com/google/nearby/
Searching for google/nearby using Xcode 14.3.1 results in nothing found.
The documentation should link to this GitHub page instead to make it easier to find the library.
Added https://github.com/google/nearby in SPM and this results in Xcode suggesting to check out the main branch? Why is not a specific version suggested?
Selecting "Up to Next Major Version" and typing in 1.0.0 results in:
"Failed to resolve dependencies Dependencies could not be resolved because no versions of 'nearby' match the requirement 1.0.0.. <2.0.0 and root depends o..."
What did you expect to happen?
Library was successfully added to project.
How can we reproduce it (as minimally and precisely as possible)?
Notice that nothing is found when using the search term provided on this page.
How often does this bug happen?
Every time
Standalone code to reproduce the issue
No response
Relevant log output
No response
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: