Crash in libaudioutils memcpy_to_i16_from_float

[sonicdebris]

We have been receiving reports of the following crash through the play console. It looks like all are on Android 10:

#00  pc 000000000000f638  /system/lib64/libaudioutils.so (memcpy_to_i16_from_float+216)
  #00  pc 0000000000040224  /system/lib64/libaaudio.so (flowgraph::SinkI16::read(void*, int)+164)
  #00  pc 0000000000034c64  /system/lib64/libaaudio.so (aaudio::AudioStreamInternalPlay::writeNowWithConversion(void const*, int)+356)
  #00  pc 00000000000346c0  /system/lib64/libaaudio.so (aaudio::AudioStreamInternalPlay::processDataNow(void*, int, long, long*)+528)
  #00  pc 0000000000031ea8  /system/lib64/libaaudio.so (aaudio::AudioStreamInternal::processData(void*, int, long)+376)
  #00  pc 0000000000034234  /system/lib64/libaaudio.so (aaudio::AudioStreamInternalPlay::callbackLoop()+316)
  #00  pc 000000000001d388  /system/lib64/libaaudio.so (AudioStream_internalThreadProc(void*) [clone .cfi]+224)
  #00  pc 00000000000e3b24  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+36)
  #00  pc 0000000000085330  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64)

We are unable to reproduce it ourselves, and I it looks like it's related to AAudio so not really an Oboe issue, but maybe there's some obvious way we might be misusing the Oboe API or something that can be fixed with a device or android version specific quirk?

I've noticed other people encountered the same issue:
https://www.audiokinetic.com/qa/7573/libaudioutils-memcpy_to_i16_from_float-memcpy_to_i16_from_float
https://forum.juce.com/t/android-audio-application-template-crashing-at-start-up-on-samsung-s9/44003
But no helpful info there.

[philburk]

@sonicdebris - thanks for the report. I have a few questions.

What version of Oboe are you using?

What devices are you seeing this on?

Generally this sort of problem occurs when a stream is closed while the callback is still running. Then the callback accesses freed memory. We have prevented the race conditions in AAudio in R and S. And we added workarounds to Oboe 1.5.0 that should prevent it on older versions. I recommend using the latest Oboe.

The key is to wait a few msec between stop and close. See PR #1017

Maybe we are not delaying enough. Increasing kDelayBeforeCloseMillis might solve this.

This issue is often associated with a disconnect event: #953

[sonicdebris]

Thanks for looking into this. We are using oboe 1.5.1 and the play console reports are all from three devices:

• Samsung Galaxy S9
• Samsung Galaxy S9+
• Samsung Galaxy Note9

All of them running Android 10 (Q).

We already plan upgrading to the latest Oboe, and will try and increase kDelayBeforeCloseMillis.

[philburk]

@sonicdebris - Did you try increasing kDelayBeforeCloseMillis ?

[danoli3]

Can confirm issue is present in latest Oboe for

• Samsung Galaxy S9+
• Samsung Galaxy Note9

backtrace:
  #00  pc 000000000000f638  /system/lib64/libaudioutils.so (memcpy_to_i16_from_float+216)
  #00  pc 0000000000040224  /system/lib64/libaaudio.so (flowgraph::SinkI16::read(void*, int)+164)
  #00  pc 0000000000034c64  /system/lib64/libaaudio.so (aaudio::AudioStreamInternalPlay::writeNowWithConversion(void const*, int)+356)
  #00  pc 00000000000346c0  /system/lib64/libaaudio.so (aaudio::AudioStreamInternalPlay::processDataNow(void*, int, long, long*)+528)
  #00  pc 0000000000031ea8  /system/lib64/libaaudio.so (aaudio::AudioStreamInternal::processData(void*, int, long)+376)
  #00  pc 0000000000034234  /system/lib64/libaaudio.so (aaudio::AudioStreamInternalPlay::callbackLoop()+316)
  #00  pc 000000000001d388  /system/lib64/libaaudio.so (AudioStream_internalThreadProc(void*) [clone .cfi]+224)
  #00  pc 00000000000e3b24  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+36)
  #00  pc 0000000000085330  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64)

[philburk]

@sonicdebris and @danoli3 - Are you using the std::shared_ptr for the OboeStream?

std::shared_ptr<oboe::AudioStream> mStream;

[danoli3]

Yes however it is static
static std::shared_ptr<oboe::AudioStream> audioStream;

[sonicdebris]

@sonicdebris and @danoli3 - Are you using the std::shared_ptr for the OboeStream?

Yes, we are.