Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuirksManager doesn't respect OboeGlobals::areWorkaroundsEnabled() #1589

Closed
robertwu1 opened this issue Aug 4, 2022 · 2 comments · Fixed by #1590
Closed

QuirksManager doesn't respect OboeGlobals::areWorkaroundsEnabled() #1589

robertwu1 opened this issue Aug 4, 2022 · 2 comments · Fixed by #1590
Assignees
Labels
bug discuss talk about during sync meeting

Comments

@robertwu1
Copy link
Collaborator

Several places in QuirksManager.cpp do not respect areWorkaroundsEnabled(). This does not cause any changes to the end user.

This means that OboeTester is doing sample rate conversion and I16 to Float conversions even when the areWorkaroundsEnabled() checkbox is not checked.

I'm not completely sure whether this is a bug or WAI.

@robertwu1 robertwu1 added bug discuss talk about during sync meeting labels Aug 4, 2022
@robertwu1 robertwu1 self-assigned this Aug 4, 2022
@robertwu1
Copy link
Collaborator Author

This means the data test path may be test different things than intended.

@philburk
Copy link
Collaborator

philburk commented Aug 7, 2022

Some conversions are workarounds, required to fix a bug, and gated by the flag. Some conversions are requested by the developers, maybe to optimize the data path, and not gated by the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug discuss talk about during sync meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants