Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use FLOAT on Vivo devices before M #201

Closed
philburk opened this issue Aug 31, 2018 · 7 comments · Fixed by #1590
Closed

don't use FLOAT on Vivo devices before M #201

philburk opened this issue Aug 31, 2018 · 7 comments · Fixed by #1590
Assignees
Labels
Milestone

Comments

@philburk
Copy link
Collaborator

philburk commented Aug 31, 2018

It was not properly supported. Use PCM16 or reject.

Try __system_property_get("ro.product.manufacturer", buf);

See https://www.google.com/url?q=https://crbug.com/737188

@philburk philburk changed the title don't use FLOAT on Vevo devices before M don't use FLOAT on Vivo devices before M Aug 31, 2018
@dturner dturner added this to the future milestone Sep 6, 2018
@philburk
Copy link
Collaborator Author

philburk commented Mar 5, 2019

After the flowgraph code is in we can convert float=>int16 on those devices.
Also see related code at:
https://github.com/google/oboe/blob/master/src/opensles/AudioOutputStreamOpenSLES.cpp#L119

@dturner
Copy link
Collaborator

dturner commented Mar 5, 2019

We need a check in the stream open method:

If device == Vivo && android version <= M && requested format is float then:
return InvalidFormat

Longer term we can do float->int16 conversion using flowgraph

@philburk
Copy link
Collaborator Author

Fix as part of #493

@gkasten
Copy link
Contributor

gkasten commented Oct 14, 2019

Can this be marked Closed? (see Jun 11 above)

@philburk philburk added bug and removed duplicate labels Oct 14, 2019
@philburk
Copy link
Collaborator Author

We can do float to int16 conversion now. But we need to recognize vivo devices.
What can we query to detect a vivo device?

If anyone has a Vivo device running Lollipop, please enter:

adb shell getprop > vivoprops.txt

and then attach the vivoprops.txt file to this bug. Thanks.

@robertwu1
Copy link
Collaborator

We can use either ro.product.brand=vivo or ro.product.manufacturer=vivo

@robertwu1
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants