-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage build is failing because of a new fuzz target #4039
Comments
Looks like the build has failed only once and it didn't raise a build failure issue in the bug tracker
which is WAI, as you noted new projects / fuzz targets are creating such circumstances under certain timing conditions. |
As I mentioned in #3902 Monorail isn't the only place where the status of coverage builds is visible. If failures like that are expected I don't think it should fail.
As you might have noticed #3902 was fixed in #3903 so I think to be consistent it would probably make sense to fix this edge case. |
Sorry, I was out for two months and haven't followed changes too closely during that time. The problem here is that we can't distinguish between a new fuzz target and a broken fuzz target that doesn't have a corpus backup available for some other reason. Technically, we can engineer it, but it's not worth the effort. The real solution would be to make the badge follow the build status logic employed by the infrastructure, because in addition to cases like this there are other flaky failures happening from time to time. Frankly I didn't remember that status for the badges is being determined differently. I'll double check it and file another issue if that's the case. As for #3903, I'd rather revert it for pretty much the same reason. Temporary false positives are better than permanent false negatives. |
It seems to be a variation on #3902. The only difference is that apart from a new fuzz target, the project itself has just been added.
https://oss-fuzz-build-logs.storage.googleapis.com/log-d8f28a49-e95e-47f7-a43b-ee20a59c3eee.txt
The text was updated successfully, but these errors were encountered: