-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly better handling of MSAN reports #863
Comments
Why are there two distinct problems? It looks like |
This is just a dumb example to show the problem :) In the real code the This is a real problem i'm having (well, finding/fixing) in the rawspeed |
But how do you want to deduplicate those cases if the use-of-uninitialized-value happens outside of |
I'm not sure if there's anything we can do here to catch this case as distinct reports -- it seems to me that this is not feasible. I'm going to say this is WAI, but happy to discuss more if you have any suggestions though. |
By comparing the sets of Features each of the crash testcase triggers. |
Another idea. Please compare these two issues: The Stacktraces specified in "Uninitialized value was created by a heap allocation" differ. That wouldn't help with the case i presented in the first comment here, obviously. |
Do you want these two bugs be filed as a single one? I think it would be so, but the second bug got fixed before the first got filed, this is why those are reporter separately. //cc @inferno-chromium |
No, exactly the opposite.
That is exactly the problem. So far, there is exactly one of these bugs open at any point in time. Thus i'm bringing up the issue, that deduplication is not ideal. |
Any thoughts on this? Or would taking the allocation trace into account result in too many duplicates too? |
That sounds like a potential improvement. Not a priority right now, but let's keep the issue open. Thanks! |
And the pattern continues... |
Yeah, the code is not open source... |
@LebedevRI - code is open source and patch can be provided there if possible. |
I may be completely wrong here, but i'm under the impression that currently the reports
from memory sanitizer are deduplicated by the "Crash State", and then reported, correct?
Consider the following pseudo-code:
There are two distinct problems, but currently i believe oss-fuzz would only report one,
and only after it is fixed, report the second-one.
The text was updated successfully, but these errors were encountered: