-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for non-versioned dependencies? #307
Comments
Mmh it looks like |
@erikvarga @another-rex thoughts? We have plans to support full dependency resolution for requirements.txt next year via deps.dev resolvers. This will give the most accurate results that we can just basing off an unlocked requirements.txt. CC @cuixq who can probably add more detail here! |
I think it makes sense to have two extractors here (also what we do for Maven):
|
I think we definitely should parse packages in requirements.txt without versions I believe we had a similar discussion during the initial migration of osv-scanner extractors to osv-scalibr. For vulnerability scanning, not having a version is not very useful (except in cases of malicious packages and unfixed vulns), but for SBOM generation even packages without a version should be accounted for. |
Yes, it should be fine to report packages that don't have any versions associated (or where we currently don't support version resolution, e.g. < and >). Feel free to send a PR for this. |
Is there a standard format for Additionally, the attached |
I just noticed that the requirements.txt extractor silently ignores all Python packages listed in
requirements.txt
without a version.I see in the tests that this is intentional. We have some use cases where returning the package list without versions (and also producing unversioned purls) would be useful. Could this be a configurable behavior?
I'm happy to submit a patch to support this in Python, I just wanted to check if you'd consider it.
The text was updated successfully, but these errors were encountered: