Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore running linting on just new changes #346

Open
G-Rath opened this issue Dec 11, 2024 · 0 comments
Open

Explore running linting on just new changes #346

G-Rath opened this issue Dec 11, 2024 · 0 comments

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented Dec 11, 2024

Currently the internal CI used for this codebase does not run golangci-lint meaning it's possible for linting violations to be introduced through internal patches, which then cause CI runs for contributions via GitHub to error on unrelated code.

While in the long-run it's hoped that the majority of contributions will be done through GitHub, in the meantime we should explore if we can have golangci-lint run on just the changes in an particular pull request

@G-Rath G-Rath changed the title Consider running linting on just new changes Explore running linting on just new changes Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant