You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the internal CI used for this codebase does not run golangci-lint meaning it's possible for linting violations to be introduced through internal patches, which then cause CI runs for contributions via GitHub to error on unrelated code.
While in the long-run it's hoped that the majority of contributions will be done through GitHub, in the meantime we should explore if we can have golangci-lint run on just the changes in an particular pull request
The text was updated successfully, but these errors were encountered:
G-Rath
changed the title
Consider running linting on just new changes
Explore running linting on just new changes
Dec 11, 2024
Currently the internal CI used for this codebase does not run
golangci-lint
meaning it's possible for linting violations to be introduced through internal patches, which then cause CI runs for contributions via GitHub to error on unrelated code.While in the long-run it's hoped that the majority of contributions will be done through GitHub, in the meantime we should explore if we can have golangci-lint run on just the changes in an particular pull request
The text was updated successfully, but these errors were encountered: