.github/workflows/dart.yml

@@ -1,4 +1,4 @@
-# Created with package:mono_repo v6.5.4
+# Created with package:mono_repo v6.5.7
 name: Dart CI
 on:
   push:
@@ -35,27 +35,27 @@ jobs:
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
       - name: mono_repo self validate
-        run: dart pub global activate mono_repo 6.5.4
+        run: dart pub global activate mono_repo 6.5.7
       - name: mono_repo self validate
         run: dart pub global run mono_repo generate --validate
   job_002:
-    name: "format_analyze; linux; Dart 2.12.0; PKG: protobuf; `dart analyze lib`, `dart analyze test`"
+    name: "format_analyze; linux; Dart 2.19.0; PKG: protobuf; `dart analyze lib`, `dart analyze test`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.12.0;packages:protobuf;commands:analyze_1-analyze_2"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:analyze_1-analyze_2"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.12.0;packages:protobuf
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.12.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.12.0"
+          sdk: "2.19.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -233,23 +233,23 @@ jobs:
         if: "always() && steps.protoc_plugin_pub_upgrade.conclusion == 'success'"
         working-directory: protoc_plugin
   job_007:
-    name: "run_tests; linux; Dart 2.12.0; PKG: protobuf; `dart test`"
+    name: "run_tests; linux; Dart 2.19.0; PKG: protobuf; `dart test`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.12.0;packages:protobuf;commands:test_0"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:test_0"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.12.0;packages:protobuf
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.12.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.12.0"
+          sdk: "2.19.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -270,23 +270,23 @@ jobs:
       - job_005
       - job_006
   job_008:
-    name: "run_tests; linux; Dart 2.17.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`"
+    name: "run_tests; linux; Dart 2.19.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:protoc_plugin;commands:command_0-command_3-test_0"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin;commands:command_0-command_3-test_0"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:protoc_plugin
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.17.0"
+          sdk: "2.19.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -397,23 +397,23 @@ jobs:
       - job_005
       - job_006
   job_011:
-    name: "run_tests; osx; Dart 2.12.0; PKG: protobuf; `dart test`"
+    name: "run_tests; osx; Dart 2.19.0; PKG: protobuf; `dart test`"
     runs-on: macos-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:macos-latest;pub-cache-hosted;sdk:2.12.0;packages:protobuf;commands:test_0"
+          key: "os:macos-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf;commands:test_0"
           restore-keys: |
-            os:macos-latest;pub-cache-hosted;sdk:2.12.0;packages:protobuf
-            os:macos-latest;pub-cache-hosted;sdk:2.12.0
+            os:macos-latest;pub-cache-hosted;sdk:2.19.0;packages:protobuf
+            os:macos-latest;pub-cache-hosted;sdk:2.19.0
             os:macos-latest;pub-cache-hosted
             os:macos-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.12.0"
+          sdk: "2.19.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -471,13 +471,13 @@ jobs:
       - job_005
       - job_006
   job_013:
-    name: "run_tests; windows; Dart 2.12.0; PKG: protobuf; `dart test`"
+    name: "run_tests; windows; Dart 2.19.0; PKG: protobuf; `dart test`"
     runs-on: windows-latest
     steps:
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.12.0"
+          sdk: "2.19.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
@@ -525,23 +525,23 @@ jobs:
       - job_005
       - job_006
   job_015:
-    name: "run_legacy_tests; linux; Dart 2.17.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test legacy_tests/generated_message_test.dart`"
+    name: "run_legacy_tests; linux; Dart 2.19.0; PKG: protoc_plugin; `./../tool/setup.sh`, `make protos`, `dart test legacy_tests/generated_message_test.dart`"
     runs-on: ubuntu-latest
     steps:
       - name: Cache Pub hosted dependencies
         uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
         with:
           path: "~/.pub-cache/hosted"
-          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:protoc_plugin;commands:command_0-command_3-test_1"
+          key: "os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin;commands:command_0-command_3-test_1"
           restore-keys: |
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0;packages:protoc_plugin
-            os:ubuntu-latest;pub-cache-hosted;sdk:2.17.0
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0;packages:protoc_plugin
+            os:ubuntu-latest;pub-cache-hosted;sdk:2.19.0
             os:ubuntu-latest;pub-cache-hosted
             os:ubuntu-latest
       - name: Setup Dart SDK
         uses: dart-lang/setup-dart@d6a63dab3335f427404425de0fbfed4686d93c4f
         with:
-          sdk: "2.17.0"
+          sdk: "2.19.0"
       - id: checkout
         name: Checkout repository
         uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab

.gitignore

@@ -9,3 +9,13 @@ packages
 pubspec.lock
 benchmarks/out
 doc/
+
+# `dart compile exe` outputs
+*.exe
+
+# `dart compile js` outputs
+*.js*
+
+# `dart compile wasm` outputs
+*.wasm
+*.mjs

analysis_options.yaml

@@ -1,22 +1,16 @@
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   language:
     strict-casts: true
+  errors:
+    lines_longer_than_80_chars: ignore
 
 linter:
   rules:
-  - always_declare_return_types
   - avoid_bool_literals_in_conditional_expressions
-  - camel_case_types
   - comment_references
-  - directives_ordering
-  - no_leading_underscores_for_local_identifiers
-  - omit_local_variable_types
+  - prefer_final_in_for_each
+  - prefer_final_locals
   - prefer_relative_imports
-  - prefer_single_quotes
-  - prefer_spread_collections
-  - sort_pub_dependencies
-  - throw_in_finally
-  - type_annotate_public_apis
-  - unawaited_futures
+  - use_super_parameters

api_benchmark/analysis_options.yaml

@@ -3,3 +3,5 @@ include: ../analysis_options.yaml
 analyzer:
   language:
     strict-casts: false
+  errors:
+    only_throw_errors: ignore

api_benchmark/lib/benchmark.dart

@@ -52,7 +52,7 @@ abstract class Benchmark {
       {Profiler? profiler}) sync* {
     checkRequest(r);
 
-    var sampleMillis = r.duration;
+    final sampleMillis = r.duration;
     setup();
 
     for (var i = 0; i < samples; i++) {
@@ -61,7 +61,7 @@ abstract class Benchmark {
 
     if (profiler != null) {
       profiler.startProfile(r);
-      var s = _measureOnce(sampleMillis);
+      final s = _measureOnce(sampleMillis);
       profiler.endProfile(s);
     }
 
@@ -84,7 +84,7 @@ abstract class Benchmark {
       return 1;
     }, 100);
 
-    var sample = _measureFor(exercise, sampleMillis);
+    final sample = _measureFor(exercise, sampleMillis);
     setCounts(sample);
     return sample;
   }
@@ -121,10 +121,10 @@ abstract class Benchmark {
   String summarizeResponse(pb.Response r) {
     checkRequest(r.request);
 
-    var prefix = summary.padRight(39);
-    var sampleCount = r.samples.length.toStringAsFixed(0).padLeft(2);
-    var median = measureSample(medianSample(r)).toStringAsFixed(0).padLeft(4);
-    var max = measureSample(maxSample(r)).toStringAsFixed(0).padLeft(4);
+    final prefix = summary.padRight(39);
+    final sampleCount = r.samples.length.toStringAsFixed(0).padLeft(2);
+    final median = measureSample(medianSample(r)).toStringAsFixed(0).padLeft(4);
+    final max = measureSample(maxSample(r)).toStringAsFixed(0).padLeft(4);
 
     return '$prefix samples: $sampleCount'
         ' median: $median max: $max $measureSampleUnits';
@@ -133,19 +133,19 @@ abstract class Benchmark {
   /// Returns the sample with the median measurement.
   pb.Sample? medianSample(pb.Response? response) {
     if (response == null || response.samples.isEmpty) return null;
-    var samples = [...response.samples];
+    final samples = [...response.samples];
     samples.sort((a, b) {
       return measureSample(a).compareTo(measureSample(b));
     });
-    var index = samples.length ~/ 2;
+    final index = samples.length ~/ 2;
     return samples[index];
   }
 
   /// Returns the sample with the highest measurement.
   pb.Sample? maxSample(pb.Response? response) {
     if (response == null) return null;
     pb.Sample? best;
-    for (var s in response.samples) {
+    for (final s in response.samples) {
       best ??= s;
       if (measureSample(best) < measureSample(s)) {
         best = s;
@@ -166,10 +166,10 @@ abstract class Benchmark {
   /// Executes [runner] repeatedly until [minimumMillis] has been reached.
   /// [runner] should return the number of times it ran the benchmark.
   static pb.Sample _measureFor(int Function() runner, int minimumMillis) {
-    var minimumMicros = minimumMillis * 1000;
+    final minimumMicros = minimumMillis * 1000;
     var reps = 0;
     var elapsed = 0;
-    var watch = Stopwatch()..start();
+    final watch = Stopwatch()..start();
     while (elapsed < minimumMicros) {
       reps += runner();
       elapsed = watch.elapsedMicroseconds;

api_benchmark/lib/benchmarks/get_strings.dart

@@ -4,7 +4,7 @@
 
 import '../benchmark.dart';
 import '../generated/benchmark.pb.dart'
-    show BenchmarkID, Request, Params, Sample;
+    show BenchmarkID, Params, Request, Sample;
 import '../generated/string_grid.pb.dart' as pb;
 
 /// A benchmark that accesses each value in a grid of string fields.
@@ -18,13 +18,13 @@ class GetStringsBenchmark extends Benchmark {
 
   @override
   String get summary {
-    var fill = fillValue == null ? 'null' : "'$fillValue'";
+    final fill = fillValue == null ? 'null' : "'$fillValue'";
     return '${id.name}($height x $fill)';
   }
 
   @override
   Params makeParams() {
-    var p = Params()..messageCount = height;
+    final p = Params()..messageCount = height;
     if (fillValue != null) p.stringValue = fillValue!;
     return p;
   }
@@ -36,13 +36,13 @@ class GetStringsBenchmark extends Benchmark {
 
   // makes a rectangle where every cell has the same value.
   static pb.Grid10 _makeGrid(int height, String? fillValue) {
-    var grid = pb.Grid10();
+    final grid = pb.Grid10();
 
     for (var y = 0; y < height; y++) {
-      var line = pb.Line10();
+      final line = pb.Line10();
       if (fillValue != null) {
         for (var x = 0; x < width; x++) {
-          var tag = getTagForColumn(line, x);
+          final tag = getTagForColumn(line, x);
           line.setField(tag, fillValue);
         }
       }
@@ -76,7 +76,7 @@ class GetStringsBenchmark extends Benchmark {
 
   void _getDefaults() {
     var ok = true;
-    for (var line in grid.lines) {
+    for (final line in grid.lines) {
       ok = ok && line.cell1.isEmpty;
       ok = ok && line.cell2.isEmpty;
       ok = ok && line.cell3.isEmpty;
@@ -93,7 +93,7 @@ class GetStringsBenchmark extends Benchmark {
 
   void _getStrings() {
     var ok = true;
-    for (var line in grid.lines) {
+    for (final line in grid.lines) {
       ok = ok && line.cell1.isNotEmpty;
       ok = ok && line.cell2.isNotEmpty;
       ok = ok && line.cell3.isNotEmpty;