Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using functools.partial as a class leads to spurious errors #322

Closed
rchen152 opened this issue May 22, 2019 · 3 comments
Closed

using functools.partial as a class leads to spurious errors #322

rchen152 opened this issue May 22, 2019 · 3 comments
Labels
bug

Comments

@rchen152
Copy link
Contributor

rchen152 commented May 22, 2019 •
edited
Loading

python/typeshed@e45f443 changed the definition of functools.partial from a class to a function. Things like isinstance() now cause spurious errors.
@rchen152 rchen152 added the bug label May 22, 2019
@tseaver
Copy link

tseaver commented May 22, 2019

@rchen152 Per our discussion on googleapis/google-cloud-python#8106, I think it was the other way around (from a class / type to a function).

@tseaver
Copy link

tseaver commented May 22, 2019

Oops, the relevant discussion is on googleapis/google-cloud-python#8097.

@rchen152
Copy link
Contributor Author

You're absolutely right - fixed.

@jekbradbury jekbradbury mentioned this issue May 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @rchen152