We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The first ID_Encoding test caught me by surprise, since it does not appear to match the RFC:
ID_Encoding
// /foo/bar?baz=http://foo.bar stays unencoded. { const absl::string_view robotstxt = "User-agent: FooBot\n" "Disallow: /\n" "Allow: /foo/bar?qux=taz&baz=http://foo.bar?tar&par\n"; EXPECT_TRUE(IsUserAgentAllowed( robotstxt, "FooBot", "http://foo.bar/foo/bar?qux=taz&baz=http://foo.bar?tar&par")); }
However, section 2.2.2 of the REP RFC seems to indicate that /foo/bar?baz=http://foo.bar should be encoded as /foo/bar?baz=http%3A%2F%2Ffoo.bar.
/foo/bar?baz=http://foo.bar
/foo/bar?baz=http%3A%2F%2Ffoo.bar
I can't decide if I'm mis-reading the RFC or if the test intentionally deviates from the RFC in this case.
Thanks!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The first
ID_Encoding
test caught me by surprise, since it does not appear to match the RFC:However, section 2.2.2 of the REP RFC seems to indicate that
/foo/bar?baz=http://foo.bar
should be encoded as/foo/bar?baz=http%3A%2F%2Ffoo.bar
.I can't decide if I'm mis-reading the RFC or if the test intentionally deviates from the RFC in this case.
Thanks!
The text was updated successfully, but these errors were encountered: