Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore or warn on setrlimit(RLIMIT_AS) #166

Open
ramosian-glider opened this issue Aug 31, 2015 · 6 comments
Open

ignore or warn on setrlimit(RLIMIT_AS) #166

ramosian-glider opened this issue Aug 31, 2015 · 6 comments

Comments

@ramosian-glider
Copy link
Member

Originally reported on Google Code with ID 166

asan should do something with setrlimit(RLIMIT_AS): 

Choices: 
1. silently ignore and return 0 (success)
2. silently ignore and return -1 (failure). What should be errno then? 
3. print a warning and return -1
4. print a warning and die
5. ??? 

Thoughts? 

We need this in sanitizer_common for tsan and msan

Reported by konstantin.s.serebryany on 2013-03-12 14:11:21

@ramosian-glider
Copy link
Member Author

Print a warning (with a stack trace) and proceed with setrlimit().
Guessing which limit the guest app is hard - let's leave it for the user.

Reported by glider@chromium.org on 2013-03-12 14:17:49

@ramosian-glider
Copy link
Member Author

I've been using the attached patch to debug Chrome recently.

Reported by ramosian.glider on 2013-03-12 14:22:01


- _Attachment: [setrlimit.patch](https://storage.googleapis.com/google-code-attachments/address-sanitizer/issue-166/comment-2/setrlimit.patch)_

@ramosian-glider
Copy link
Member Author

FTR, two more questions risen today:
 - each tool may need to act differently when setrlimit is called
 - this is a common code and should live in sanitizer_common, but we don't have common
flags yet

Reported by ramosian.glider on 2013-03-12 15:23:58

@ramosian-glider
Copy link
Member Author

Can you give an example of different behavior?
Option 4 looks fine to me.

Reported by vonosmas on 2013-03-12 18:26:38

@morehouse
Copy link
Contributor

@kcc: What is the status of this?

@kcc
Copy link
Contributor

kcc commented Jun 5, 2018

no idea :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants