Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shared libraries "properly" #994

Open
dneto0 opened this issue Mar 6, 2020 · 1 comment
Open

Support shared libraries "properly" #994

dneto0 opened this issue Mar 6, 2020 · 1 comment
Labels
version/release Packaging, versioning, installing, prebuilt artifacts

Comments

@dneto0
Copy link
Collaborator

dneto0 commented Mar 6, 2020

See also KhronosGroup/SPIRV-Tools#3214

@dneto0 dneto0 added the version/release Packaging, versioning, installing, prebuilt artifacts label Mar 6, 2020
@BurningEnlightenment
Copy link

As a bystander who just had to rewrite the shaderc vcpkg port I can say that this would be a nice thing to have.
Additionally I recommend bumping the required cmake version to something >= 3.5 and refactor/modernize the cmake buildfiles to fully utilize the power of cmake targets. Compiler flag propagation through target dependency chains could remove a lot of the repeatedly specified settings like include directories, link dependencies, preprocessor definitions, etc. It would also allow for proper target install configs which in turn would allow find_package(shaderc) to just work™️. Bonus points if find_package(glslang CONFIG) & find_package(SPIRV-Tools CONFIG) get asked allowing the user to easily provide the dependencies himself.
If the modern cmake approach is deemed worth a try, feel free to ping me in case you encounter obstacles/unclear stuff. I have spend quite some time writing cmake buildsystems and wouldn't mind sharing some of the lessons I learned.

However, thanks for all the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/release Packaging, versioning, installing, prebuilt artifacts
Projects
None yet
Development

No branches or pull requests

2 participants