Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move js dependencies required for backstop tests into their own workspace #10093

Open
4 tasks
eugene-manuilov opened this issue Jan 21, 2025 · 1 comment
Open
4 tasks
Assignees
Labels
P2 Low priority QA: Eng Requires specialized QA by an engineer Team M Issues for Squad 2 Type: Infrastructure Engineering infrastructure & tooling

Comments

@eugene-manuilov
Copy link
Collaborator

eugene-manuilov commented Jan 21, 2025

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The package.json file is updated to have tests/backstop in the workspaces array.
  • JavaScript dependencies that are needed for backstop to function properly are moved to the new workspace.
  • GitHub actions for vrt are updated accordingly to continue running for all PRs.

Implementation Brief

  • Update package.json, adding a new workspace "tests/backstop".
  • Create a new package.json file in tests/backstop folder using npm init -w ./tests/backstop.
    • Copy the scripts for backstop tests but not for building storybook to this new package.json:
      • test:visualtest
      • test:visualapprove
      • backstopjs
        Fix any paths and ensure the commands work correctly after the refactor.
  • Scan all dependencies that we have in the main package.json file and move all dependencies that are used in backstop tests to its own package by uninstalling them in the main package.json file and installing with -w ./tests/backstop argument to specify the correct workspace.
  • Update the package.json file to proxy backstop commands to the correct workspace using the npm run ... -w ./tests/backstop approach.

Test Coverage

  • N/A

QA Brief

Changelog entry

@eugene-manuilov eugene-manuilov added P2 Low priority Type: Infrastructure Engineering infrastructure & tooling labels Jan 21, 2025
@benbowler benbowler self-assigned this Jan 22, 2025
@benbowler benbowler added the QA: Eng Requires specialized QA by an engineer label Jan 22, 2025
@benbowler benbowler removed their assignment Jan 24, 2025
@techanvil techanvil self-assigned this Jan 27, 2025
@techanvil
Copy link
Collaborator

IB ✅

@techanvil techanvil removed their assignment Jan 27, 2025
@benbowler benbowler self-assigned this Jan 27, 2025
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority QA: Eng Requires specialized QA by an engineer Team M Issues for Squad 2 Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

4 participants