Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Behaviour on Create a Goal CTA on SK Dashboard #3392

Closed
wpdarren opened this issue May 24, 2021 · 1 comment
Closed

Link Behaviour on Create a Goal CTA on SK Dashboard #3392

wpdarren opened this issue May 24, 2021 · 1 comment
Labels
duplicate Reason for closed issues Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented May 24, 2021 •
edited
Loading

Bug Description

On the Site Kit dashboard, when you click the Create a Goal CTA link, it opens up in the same window.

To be consistent with external links, the link should open in a new window.

image

Steps to reproduce

  1. Make sure Google Analytics is connected
  2. Go to Site Kit Dashboard
  3. Scroll down to Create a Goal CTA
  4. Click on the link

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

Visual Regression Changes

QA Brief

Changelog entry
@wpdarren wpdarren added Type: Enhancement Improvement of an existing feature Module: Analytics Google Analytics module related issues labels May 24, 2021
@wpdarren wpdarren changed the title Link Behaviour on Create a Goal CTR on SK Dashboard Link Behaviour on Create a Goal CTA on SK Dashboard May 24, 2021
@aaemnnosttv aaemnnosttv added the P2 Low priority label Jun 1, 2021
@aaemnnosttv aaemnnosttv self-assigned this Jun 1, 2021
@aaemnnosttv
Copy link
Collaborator

Closing in favor of #3683 which addresses the same thing 👍

@aaemnnosttv aaemnnosttv added the duplicate Reason for closed issues label Sep 1, 2021
@aaemnnosttv aaemnnosttv removed their assignment Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Reason for closed issues Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaemnnosttv @wpdarren