-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed "Updated every 2-3 days" language from Idea Hub Saved and Drafts tabs #3832
Comments
@johnPhillips we need to make sure that the Pagination component is right-aligned to be consistent across all tabs. |
@eugene-manuilov I did address this (although it's not obvious from the IB!). If we simply remove the However, when the
Let me know what you think. |
Ah... ok, then it sounds good to me. Thanks, @johnPhillips. IB ✔️ |
QA Update: ✅I can confirm that the |
Bug Description
The "Updated every 2-3 days" language currently displays on all three IH tabs on the Dashboard: New, Saved, and Drafts. It should be removed from the Saved and Drafts tabs so it only displays on the New tab.
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
footerText
, to theDashboardIdeasWidget
Footer component (assets/js/modules/idea-hub/components/dashboard/DashboardIdeasWidget/Footer.js
).string
to thepropTypes
definition for the component.footerText
prop has been provided, render the current<Grid>
,<Row>
and<Cell>
output, the sole difference being to replace the'Updated every 2-3 days'
text with output of the new prop.<Pagination>
component inside a straightforward<div>
instead (with thegooglesitekit-idea-hub__footer
className applied).index
component, pass the'Updated every 2-3 days'
string as thefooterText
prop to theFooter
component only if theactiveTab
isnew-ideas
.Test Coverage
Visual Regression Changes
QA Brief
Updated every 2-3 days
language is only visible in thenew
tab.Changelog entry
The text was updated successfully, but these errors were encountered: