AdSense module shows simultaneously as "unable to set up" and "connected" in banner notification

[marrrmarrr]

Bug Description

The AdSense module is shown as simultaneously "unable to set up" and "connected" in success notices in certain situations.

Steps to reproduce

1. Ensure AdSense is connected
2. Enable any ad blocker
3. Complete setup for another service (e.g. Analytics, Idea Hub) in order to get the "success" notification on the dashboard
4. AdSense shows up in the list as simultaneously "connected" and "impossible to set up"

Screenshots

Additional Context

• PHP Version:
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Plugin Version [e.g. 22]
• Device: [e.g. iPhone6]

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• For cases where AdSense is already successfully connected, don't display the ad blocker warning in the success notice.

Implementation Brief

in assets/js/components/ModulesListItem.js,

• Expand the logic to not disable module here and the so an already connected (ie. setupComplete) module is not disabled.
• Only render ModuleSettingsWarning compoment here when setupComplete is falsy. ie. { ! setupComplete && <ModuleSettingsWarning slug={ slug } context="modules-list" /> }.

Test Coverage

• Not needed.

Visual Regression Changes

• Not needed.

QA Brief

• Follow steps to reproduce.
• Adblock module should only show up as connected (not disabled/impossible to set up).
• Test with Adblock Plus

Changelog entry

• Update the modules list banner not to disable connected modules.

[marrrmarrr]

@felixarntz could you have a look and if the ACs LGTY, move to IB?

[felixarntz]

@marrrmarrr Thanks, looks great!

[aaemnnosttv]

@kuasha420 I think we can simplify this to be specific to ModulesListItem only.

We only should only render ModuleSettingsWarning if the module setup isn't completed since this displays the module requirements error which was raised by the module's checkRequirements function.

Then the only other change I think we need is the logical change in when we add the disabled class, as you already identified 🙂

Regarding the variable name and other specific details of the code, this is getting into code review territory so it's best to describe the changes a little more abstractly and focus more on the logic 👍

[kuasha420]

@aaemnnosttv I've updated the IB accordingly. Please have a look.

[aaemnnosttv]

IB ✅

[cole10up]

QA ✅

Tested

Confirmed the bug here:

Reset and ran the same test to pop the issue above. Confirmed the fix:

Continued to setup all modules to confirm no other issues occurred with an ad blocker configured.

Sending to approval