Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AdSense signup URL to point to #4239

Closed
felixarntz opened this issue Oct 18, 2021 · 4 comments
Closed

Update AdSense signup URL to point to #4239

felixarntz opened this issue Oct 18, 2021 · 4 comments
Labels
Good First Issue Good first issue for new engineers Module: AdSense Google AdSense module related issues P0 High priority Type: Enhancement Improvement of an existing feature
Milestone

Comments

@felixarntz
Copy link
Member

felixarntz commented Oct 18, 2021

The AdSense "signup" URL that Site Kit points to should be updated to the URL with the newer AdSense frontend UI. Note that while the URL includes the term "signup", it can be used for users without any AdSense account as well as for users with an existing AdSense account where they just want to add a new site.

The AdSense frontend will handle this accordingly based on the current user and show the correct UI. For reference:

New UI:
Screen Shot 2021-10-18 at 12 02 57 PM

Old UI:
Screen Shot 2021-10-18 at 12 03 12 PM


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Instead of using https://www.google.com/adsense/signup/new for the AdSense "signup" URL, it should be updated to https://www.google.com/adsense/signup, which will result in a different UI being presented to the user.

Implementation Brief

Test Coverage

  • N/A

QA Brief

  • Use a Google account where you don't have any AdSense account. Make sure you're logged in in your browser with primarily that account (e.g. in an incognito window, separate from your regular accounts).
  • Set up AdSense in Site Kit, you should land in the setup step where it says to create an account.
  • When clicking the blue CTA button, you should land in an AdSense UI that looks like the one in the new screenshot on top of this issue description.

Changelog entry

  • Update AdSense signup URL to point to the latest UI.
@felixarntz felixarntz added P0 High priority Type: Enhancement Improvement of an existing feature Good First Issue Good first issue for new engineers Module: AdSense Google AdSense module related issues labels Oct 18, 2021
@felixarntz felixarntz self-assigned this Oct 18, 2021
@felixarntz felixarntz added this to the Sprint 60 milestone Oct 18, 2021
@felixarntz felixarntz assigned aaemnnosttv and unassigned felixarntz Oct 18, 2021
@felixarntz
Copy link
Member Author

@eclarke1 @aaemnnosttv This is a short-term issue that came through as requirement from AdSense while further testing the AdSense platforms tag behavior (see #3688), as they've updated their signup UI. It's a super-simple one to include, so I've marked it with the 1.44.0 release.

It's only a 1, and I've created a PR, so this shouldn't really add anything to our load :)

@aaemnnosttv
Copy link
Collaborator

IB ✅

@eclarke1
Copy link
Collaborator

cc @fhollis to this one being added to the sprint but it has a PR so shouldn't add to the load

@aaemnnosttv aaemnnosttv removed their assignment Oct 19, 2021
@wpdarren wpdarren self-assigned this Oct 19, 2021
@wpdarren
Copy link
Collaborator

QA Update: ✅

  • Set up AdSense in Site Kit, clicked the blue CTA button, and I am redirected to the new AdSense UI

image

@wpdarren wpdarren removed their assignment Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers Module: AdSense Google AdSense module related issues P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants