Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect widget area layout for new unified dashboard content area #4268

Closed
felixarntz opened this issue Oct 25, 2021 · 4 comments
Closed
Labels
Good First Issue Good first issue for new engineers P1 Medium priority Type: Bug Something isn't working
Milestone

Comments

@felixarntz
Copy link
Member

felixarntz commented Oct 25, 2021

#4031 incorrectly defined the new widget areas AREA_MAIN_DASHBOARD_CONTENT_PRIMARY and AREA_ENTITY_DASHBOARD_CONTENT_PRIMARY to use the "COMPOSITE" widget area style. This is incorrect, as these areas shouldn't render as a single box of multiple widgets, but the (more typical) grid of multiple boxes, one for each widget.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The widget area registrations for AREA_MAIN_DASHBOARD_CONTENT_PRIMARY and AREA_ENTITY_DASHBOARD_CONTENT_PRIMARY should be changed to use the "BOXES" style.

Implementation Brief

Test Coverage

  • N/A

QA Brief

  • Check the Unified Dashboard (using the unifiedDashboard feature flag) and ensure the "primary" content area shows widgets in the "boxes" style, not combined. Eg. they should match the "after" screenshots below:

Before

Screenshot 2021-10-27 at 10 29 39

After

Screenshot 2021-10-27 at 10 27 47

Changelog entry

  • Use "boxed" layout style for the unified dashboard's "content" widget area.
@felixarntz felixarntz added Type: Bug Something isn't working P1 Medium priority labels Oct 25, 2021
@felixarntz felixarntz assigned felixarntz and unassigned felixarntz Oct 25, 2021
@felixarntz felixarntz added the Good First Issue Good first issue for new engineers label Oct 25, 2021
@NaotoNakamura
Copy link
Contributor

I would like to take this issue !

@tofumatt
Copy link
Collaborator

This can be moved directly to code review after IB review, and maybe added to this sprint/release, as @NaotoNakamura already created a PR for it 🙂

@felixarntz
Copy link
Member Author

IB ✅

@felixarntz felixarntz self-assigned this Oct 27, 2021
@felixarntz felixarntz added this to the Sprint 61 milestone Oct 27, 2021
@felixarntz felixarntz removed their assignment Oct 27, 2021
@wpdarren wpdarren self-assigned this Oct 28, 2021
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

  • On the Unified Dashboard, the "primary" content area shows widgets in the "boxes" style, not combined.
  • Tested this on desktop and small screen sizes like mobile.

image

@wpdarren wpdarren removed their assignment Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants