Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants for new AdSense statuses #4755

Closed
felixarntz opened this issue Feb 1, 2022 · 2 comments
Closed

Add constants for new AdSense statuses #4755

felixarntz opened this issue Feb 1, 2022 · 2 comments
Labels
Good First Issue Good first issue for new engineers Module: AdSense Google AdSense module related issues P0 High priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling

Comments

@felixarntz
Copy link
Member

felixarntz commented Feb 1, 2022

As part of the enhanced AdSense setup flow, a few new account and site statuses will be introduced. This issue is for scaffolding all of them.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Constants for the new AdSense account and site statuses should be added, together with the existing AdSense account and site status constants. For both account and site statuses, all statuses should be separated into three groups, each annotated with a comment (see below).
  • Details on account statuses:
    • The following new account statuses should be added and annotated with a comment V2 setup flow.:
      • ACCOUNT_STATUS_PENDING_TASKS
    • The following existing account statuses should be moved together, annotated with a comment V1 setup flow.:
      • ACCOUNT_STATUS_DISAPPROVED
      • ACCOUNT_STATUS_GRAYLISTED
      • ACCOUNT_STATUS_PENDING
    • All other existing account statuses should remain together and be annotated with a comment V1 and V2 setup flow..
  • Details on site statuses:
    • The following new site statuses should be added and annotated with a comment V2 setup flow.:
      • SITE_STATUS_NEEDS_ATTENTION
      • SITE_STATUS_REQUIRES_REVIEW
      • SITE_STATUS_GETTING_READY
      • SITE_STATUS_READY
      • SITE_STATUS_READY_NO_AUTO_ADS
    • The following existing site status should be moved into its own "group", annotated with a comment V1 setup flow.:
      • SITE_STATUS_ADDED
    • All other existing site statuses should remain together and be annotated with a comment V1 and V2 setup flow..

Implementation Brief

  • Using assets/js/modules/adsense/util/status.js, add the statuses as per the AC.

Test Coverage

  • No new tests to be added.

QA Brief

QA:Eng

  • Verify the new constants are added with the comments as described in the AC
  • Verify the existing constants are grouped with the comments as described in the AC

Changelog entry

  • N/A
@felixarntz felixarntz added P0 High priority Good First Issue Good first issue for new engineers Module: AdSense Google AdSense module related issues Type: Infrastructure Engineering infrastructure & tooling labels Feb 1, 2022
@felixarntz felixarntz assigned felixarntz and unassigned felixarntz Feb 1, 2022
@felixarntz felixarntz added the QA: Eng Requires specialized QA by an engineer label Feb 1, 2022
@eugene-manuilov eugene-manuilov self-assigned this Feb 8, 2022
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Feb 8, 2022
@hussain-t hussain-t self-assigned this Feb 9, 2022
@hussain-t hussain-t removed their assignment Feb 9, 2022
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Feb 9, 2022
@asvinb asvinb self-assigned this Feb 10, 2022
@asvinb
Copy link
Collaborator

asvinb commented Feb 10, 2022

QA: ✔️

  • Statuses added and comments added as per AC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good first issue for new engineers Module: AdSense Google AdSense module related issues P0 High priority QA: Eng Requires specialized QA by an engineer Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

5 participants