Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally render SourceLinks based on view context #4815

Closed
aaemnnosttv opened this issue Feb 8, 2022 · 2 comments
Closed

Conditionally render SourceLinks based on view context #4815

aaemnnosttv opened this issue Feb 8, 2022 · 2 comments
Labels
P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Feb 8, 2022

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Any widgets that include one or more SourceLinks should be adjusted to only render these source links if not in the view-only version of the dashboard. The useViewOnly() hook introduced in Use alternate viewContext for non-authenticated users #4814 should be used to determine that.
    • The reasoning behind this change is that the links go to the Google frontend to which you'll only have access if authorized within Google's permission system. The view-only users won't have access to this in the vast majority of cases, therefore these links should not be shown.

Implementation Brief

Test Coverage

  • No new tests to be added.

QA Brief

  • All source links at the bottom of widgets should continue to appear as normal for a user not using Dashboard sharing.

Note for future QA

  • This will not be possible to QA now, but in the future when a user can browse the dashboard using Dashboard sharing in a "view-only" mode, the "Source: {Service}" links at the bottom of widgets should not appear when browsing in a read-only mode.

Changelog entry

  • Update source links to hide on the view only dashboard.
@aaemnnosttv aaemnnosttv added P0 High priority Type: Enhancement Improvement of an existing feature labels Feb 8, 2022
@aaemnnosttv aaemnnosttv self-assigned this Feb 8, 2022
@jimmymadon jimmymadon assigned jimmymadon and unassigned jimmymadon Mar 13, 2022
@eugene-manuilov eugene-manuilov self-assigned this Mar 21, 2022
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Mar 21, 2022
@tofumatt tofumatt self-assigned this Apr 12, 2022
@tofumatt tofumatt removed their assignment Apr 12, 2022
@asvinb asvinb assigned asvinb and unassigned asvinb Apr 14, 2022
@wpdarren wpdarren self-assigned this Apr 19, 2022
@wpdarren
Copy link
Collaborator

wpdarren commented Apr 19, 2022

QA Update: ✅

Verified:

  • All source links at the bottom of widgets continue to appear as normal for a user not using Dashboard sharing.
  • Went through the date periods, 7, 14, 28 and 90 days to ensure the correct data period appeared on the Search console and Analytics pages.
  • Checked widgets on main and entity dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants