Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Not enough traffic yet to display stats' notification not appearing on Entity Dashboard #4983

Closed
wpdarren opened this issue Mar 28, 2022 · 3 comments
Labels
P1 Medium priority Type: Bug Something isn't working

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Mar 28, 2022

Bug Description

The Not enough traffic yet to display stats desktop notification only appears on the main dashboard. When visiting the entity dashboard for a specific page, the notification does not appear when in zero data state. I believe that it should.

image.png


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Zero data state notifications should appear on the entity dashboard, as well as on the main dashboard

Implementation Brief

  • Create a new EntityBannerNotifications component as an entity dashboard-specific variant of the current BannerNotifications component
    • For now this would only include ZeroDataStateNotifications in the same way as it is in BannerNotifications
  • Update DashboardEntityApp to render the new EntityBannerNotifications component in the subHeader prop of the Header component, similar to DashboardMainApp

Test Coverage

  • No changes needed

QA Brief

  • Ensure zeroDataStates feature flag is enabled.
  • Using the tester plugin, enable the zero data state for Analytics and Search Console.
  • Clear the session and reload the page.
  • Ensure the Zero data state notification appears.
  • Type Sample Page in the entity search input.
  • Click the search results and go to the entity dashboard.
  • Ensure the Zero data state notification appears as it appears in the main dashboard.

zero-state-entity-dashboard

Changelog entry

  • Add "gathering data" and "zero data" headers to single URL ("entity") dashboard pages.
@wpdarren wpdarren added the Type: Bug Something isn't working label Mar 28, 2022
@tofumatt
Copy link
Collaborator

Here's a screencast of where we would expect this, just for context:

CleanShot 2022-03-30 at 13 19 02

@eclarke1 eclarke1 added the P1 Medium priority label Mar 30, 2022
@tofumatt tofumatt self-assigned this Apr 4, 2022
@tofumatt
Copy link
Collaborator

tofumatt commented Apr 4, 2022

Works for me! IB ✅

@tofumatt tofumatt removed their assignment Apr 4, 2022
@hussain-t hussain-t self-assigned this Apr 5, 2022
@hussain-t hussain-t removed their assignment Apr 5, 2022
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Apr 5, 2022
@wpdarren wpdarren self-assigned this Apr 8, 2022
@wpdarren
Copy link
Collaborator Author

wpdarren commented Apr 8, 2022

QA Update: ✅

Using the tester plugin, with zero data state for Analytics and Search Console:

  • The Zero data state notification appears on the main and entity dashboard.
  • Checked that the notifications appeared as expected on smaller screensizes.
Screenshots

image
image

QA note: When you have search console in gathering and analytics in zero (and vice versa) the notification doesn't appear on main or entity dashboard. This was discovered while QA-ing 5008 and is currently being fixed.

Will retest this when that ticket is back in QA.

@wpdarren wpdarren removed their assignment Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants