-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin header does not include requirements used by core #5076
Comments
IB ✔️ |
18 tasks
QA ✅Plugin data now includes the proper values for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
As per https://developer.wordpress.org/plugins/wordpress-org/how-your-readme-txt-works/, as of 5.8 WordPress core no longer sources plugin requirements from its
readme.txt
file, but instead from the plugin's header in its main php entrypoint.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
readme.txt
togoogle-site-kit.php
Requires at least
Minimum required version of WPRequires PHP
Minimum required version of PHPImplementation Brief
readme.txt
togoogle-site-kit.php
site-kit-wp/google-site-kit.php
Line 19 in 43693b6
Test Coverage
QA Brief
UPDATE: This is still odd to QA outside code, so I wrote a unit test that verifies the info we provided is used. If the PHP Unit tests for
test_plugin_data
pass, then if you change the value forRequires at least:
ingoogle-site-kit.php
to5.0
and the tests fails: this is good 🙂Changelog entry
The text was updated successfully, but these errors were encountered: