Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google API client services library to get latest AdSense API updates support #5092

Closed
felixarntz opened this issue Apr 14, 2022 · 3 comments
Labels
Module: AdSense Google AdSense module related issues P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@felixarntz
Copy link
Member

felixarntz commented Apr 14, 2022

In order for #5050 (and potentially other AdSense-related features) to work, based on the latest AdSense API enhancements, we need to update the google/apiclient-services PHP library to at least version 0.242.0 (latest at this point is 0.243.0).


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The google/apiclient-services PHP library needs to be updated to a version greater than or equal to 0.242.0.

Implementation Brief

Test Coverage

  • N/A

QA Brief

This needs mostly a sanity check that no module-related request unexpectedly throws an error due to the library update.

  • Set up Site Kit.
  • Go through the setup flows for the following modules:
    • AdSense (tester plugin to mock states is okay)
    • Analytics
  • Check the main dashboard and entity dashboard and verify there are no unexpected errors.

Changelog entry

  • Update Google API client services library for latest AdSense API enhancements.
@felixarntz felixarntz added P0 High priority Type: Enhancement Improvement of an existing feature Module: AdSense Google AdSense module related issues labels Apr 14, 2022
@felixarntz felixarntz self-assigned this Apr 14, 2022
@felixarntz felixarntz assigned aaemnnosttv and unassigned felixarntz Apr 14, 2022
@felixarntz
Copy link
Member Author

@aaemnnosttv This is ready for IBR / CR :)

@aaemnnosttv
Copy link
Collaborator

IB + CR ✅ 🚀

@aaemnnosttv aaemnnosttv removed their assignment Apr 14, 2022
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

  • Went through the setup flows for AdSense and Analytics.
  • Checked the main dashboard and entity dashboard and verify there are no unexpected errors.
  • Tested this with ZDS enabled and disabled.
  • Tested this with a new Analytics property and also selecting an already created property.
  • No console errors or any on-screen errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: AdSense Google AdSense module related issues P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants