-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update secondary CTA links for consistency #5184
Labels
Good First Issue
Good first issue for new engineers
P1
Medium priority
Rollover
Issues which role over to the next sprint
Type: Enhancement
Improvement of an existing feature
Comments
aaemnnosttv
added
P1
Medium priority
Type: Enhancement
Improvement of an existing feature
labels
May 5, 2022
@felixarntz should we standardize on |
@aaemnnosttv They should all look like they had the |
IB ✅ |
18 tasks
QA Update ✅Verified
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Issue
Good first issue for new engineers
P1
Medium priority
Rollover
Issues which role over to the next sprint
Type: Enhancement
Improvement of an existing feature
Feature Description
As raised in #4764 (comment) and #4764 (comment) there is an inconsistency of styling secondary links. These should be updated to be consistent.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
.googlesitekit-cta-link
styles should be adjusted to include the styles from.googlesitekit-cta-link--inherit
, basically so that all elements that use classgooglesitekit-cta-link
today will look the same as those that use classesgooglesitekit-cta-link googlesitekit-cta-link--inherit
today.googlesitekit-cta-link--inherit
as well as the style definition for this class should be removed.Implementation Brief
Using
assets/sass/components/global/_googlesitekit-cta-link.scss
,.googlesitekit-cta-link
to include the styles fromgooglesitekit-cta-link--inherit
googlesitekit-cta-link--inherit
classRemove the
googlesitekit-cta-link--inherit
class used across the codebase.Estimates a bit higher due to QA involved since it's a global change.
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: