"Can't access necessary data" notice flicker when activating Analytics via GTM setup

[aaemnnosttv]

Bug Description

When setting up Analytics via GTM setup, the unsatisfied scopes notice briefly flickers before the user is taken to the OAuth consent screen.

Kapture.2022-05-20.at.20.08.01.mp4

Steps to reproduce

1. Connect GTM using a container that has an Analytics property in the container
2. Choose the primary option to "Continue to Analytics setup"
3. Notice flicker on submit

Screenshots

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The "Site Kit can't access necessary data" for Analytics notice should not be displayed while activating Analytics via GTM setup

Implementation Brief

• In assets/js/modules/tagmanager/components/setup/SetupForm.js
  • Remove the double call to the activateModule function inside the submitForm function.
  • This line should be removed.
    

    site-kit-wp/assets/js/modules/tagmanager/components/setup/SetupForm.js

    Line 111 in 5863f68

    await throwOnError( () => activateModule( 'analytics' ) );

Test Coverage

N/A

QA Brief

• The "Can't access necessary data" notice will no longer appear or flicker when clicking on the Primary CTA after following setp to reproduce.
• Ensure the setup still works correctly (ie. GTM + Analytics are properly set up).
• Setup Tag Manager with a GTM container without Analytics property inside it to ensure GTM continues to be set up properly.

Changelog entry

• Prevent "Can't access necessary data" notice flicker when activating Analytics via GTM setup.

[eugene-manuilov]

IB ✔️

[wpdarren]

QA Update: ⚠️

@kuasha420 this might be out of scope but because it's related to the initial issue, I wanted to raise it. I can see that flicker no longer appears when you click on the 'continue to Analytics setup' button. That said, when it goes through setting up Analytics, there's another flicker where initially it loads it without the GTM message An existing Google Tag Manager property was found on your site with the ID UA-232779384-1. Since it refers to the same property selected here and then loads it. I included it on the screen cast below but jump to 0.35 seconds to see what I mean.

analytics.mp4

[kuasha420]

@wpdarren Yep, feel free to create a new issue for this one, the reason for this flicker doesn't appear to be similar. Nice spot though!

[wpdarren]

QA Update: ✅

Verified:

• I can see that flicker no longer appears when you click on the 'continue to Analytics setup' button. I was able to recreate this on the latest release, but on develop the flicker is fixed. Found an issue with the Analytics setup as part of the GTM process but will create this as an issue since it's out of scope for this ticket.

analytics.mp4