Avoid showing administration-related banner notifications in view-only dashboard

[felixarntz]

Bug Description

The view-only dashboard is currently showing banner notifications related to administration, which should not be shown in such a case of course, since the user can't act on them. See the below screenshot which shows the Idea Hub CTA banner notification to a contributor user.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• From all banner notifications part of BannerNotifications or EntityBannerNotifications, the only notification(s) that should ever be shown in a view-only context should be ZeroDataStateNotifications.

Implementation Brief

• In the BannerNotifications component:
  • Rely on useViewOnly (e.g. const viewOnly = useViewOnly()).
  • Wrap all notifications within the rendered Fragment in a check whether ! viewOnly, except for ZeroDataStateNotifications.
• EntityBannerNotifications can remain unchanged since it only contains ZeroDataStateNotifications anyway.

Test Coverage

• No new tests needed.

QA Brief

• Ensure that only zero-data state notifications display when viewing the view-only Dashboard.
• Ensure that all types of notification continue to display on the authenticated Dashboard.

Changelog entry

• Prevent admin-related notifications from appearing on view-only dashboard.

[felixarntz]

cc @aaemnnosttv @wpdarren for awareness

[aaemnnosttv]

IB ✅

[aaemnnosttv]

@techanvil would you please add a QA brief?

[techanvil]

Thanks for pointing this out @aaemnnosttv - I had added it in the Test Coverage section 🤦. Have moved to QAB, cheers.

[wpdarren]

QA Update: ⚠️

@techanvil the QAB suggests that only zero-data state notifications display when using view only dashboard. I do see the gathering state notifications though, which in my opinion, would make sense to keep being displayed. Just checking though. I tested this with an editor and admin role.

[techanvil]

Hi @wpdarren, thanks for pointing this out - in hindsight the issue could have been a bit clearer. Gathering data notifications are also relevant to non-admin users and are included in the ZeroDataStateNotifications component mentioned in the AC. So, they should still continue to be seen.

[wpdarren]

QA Update: ✅

Verified:

• Only zero-data state notifications display when viewing the view-only Dashboard.
• All types of notification continue to display on the authenticated Dashboard.

Screenshots