Goals CTA widget appears on shared dashboard

[eclarke1]

Bug Description

Bug bash issue: https://app.asana.com/0/1202258919887896/1202419766205815 please refer to Asana issue for background

When the non-authenticated user (editor) has access to Analytics, the Goals CTA appears on the shared dashboard. It's my understanding that this should not appear.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The Analytics "Goals" CTA should not appear in any shared dashboard context; it should only appear when the user viewing the dashboard has authenticated with Site Kit

Implementation Brief

• Using assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/Overview.js,
  • Render CreateGoalCTA or CTA if the user has been authenticated by querying the core/user data store via the isAuthenticated selector.

Test Coverage

• No new tests to be added.

QA Brief

• Ensure that the Goals CTA doesn't appear for non-authenticated users with view-only access to Analytics as mentioned in the AC.
• Ensure that it appears for the authenticated users.

Changelog entry

• Do not show "Create Goals" widget on shared dashboard.

[aaemnnosttv]

• it should only appear when the user viewing the dashboard has authenticated with Site Kit and has access to the Analytics account

@tofumatt we don't currently have a way to check if the user has that kind of access to the account/property. It may be possible to request through the management API but this would substantially increase the effort needed for this change and we don't do it now so I'm going to remove that detail. We can always revisit it later in a follow-up 👍

[tofumatt]

Ah, fair enough on the access bit. In that case, looks good!

IB ✅

[techanvil]

Hi @hussain-t, please could you add a QA Brief for this issue?

[hussain-t]

OMG, how did I miss that! Thanks for catching it, @techanvil 👍

[techanvil]

Thanks @hussain-t, that's great. Moving back over to QA :)

[mohitwp]

QA Update ✅

Verified 👍

• Verified for admin user when admin user not signed in and access dashboard in view only mode.
• Verified for other non authenticated users.
• Now 'Goals CTA widget' is not appearing for users having only 'View only' access.

Admin user 'View only' dashboard

Editor User