-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement modules/thank-with-google
JS store foundation
#5365
Comments
@kuasha420, please, do not use "PR as IB" approach for regular tickets, we strongly discourage this approach even if a ticket seems pretty straightforward. IB ✔️ |
QA Update:
|
QA Update: ✅Thank you @kuasha420 @nfmohit 👍 Verified:
|
Similar to #5364: We should "migrate" the
modules/subscribe-with-google
store to become the foundation for a newmodules/thank-with-google
store.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
modules/subscribe-with-google
should be consistently renamed tomodules/thank-with-google
.googlesitekit-modules-subscribe-with-google.js
should be renamed togooglesitekit-modules-thank-with-google.js
.subscribe-with-google
module slug in JS should be changed to reference thethank-with-google
module slug (see Implement Thank with Google PHP module foundation #5364).swgModule
feature flag in JS should be changed to reference thetwgModule
feature flag (see Implement Thank with Google PHP module foundation #5364).@since
annotations within the (renamed)assets/js/modules/thank-with-google
directory should be changed ton.e.x.t.
, de-facto making this code new.Implementation Brief
Note: The ACs are very close to code here already, so no need to rehash all of this. Please review the ACs closely together with the relevant code and point out any more complex changes necessary or follow-up questions.
assets/js/modules/subscribe-with-google
toassets/js/modules/thank-with-google
.subscribe-with-google
withthank-with-google
in code and file names inside the directory.Subscribe with Google
.assets/js/modules/**thank**-with-google/datastore/constants.js
modules/subscribe-with-google
asMODULES_THANK_WITH_GOOGLE
.STORE_NAME
constant.STORE_NAME
withMODULES_THANK_WITH_GOOGLE
constant.webpack.config.js
file:googlesitekit-modules-subscribe-with-google
entry togooglesitekit-modules-thank-with-google
and use the new path (post rename).Subscribe_With_Google/Thank_With_Google
class:assets/js/modules/thank-with-google/index.js
:twgModule
.thank-with-google.svg
to graphics directory.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: