-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TwG setup UI for publication in review scenario #5527
Comments
IB ✅ |
QA Update:
|
Thank you for spotting this @wpdarren! I believe the AC and IB were written using the second iteration of the Figma design, which I followed mistakenly as well. I'm moving this back to execution to add a new PR updating the button design to match with the latest iteration (iteration four). |
Ready for another pass @wpdarren 👍 |
QA Update: ✅Verified:
Note: there are some font type/size differences and these were also flagged in 5528 The response was that what we are seeing is correct, because the figma are focused on GM3, and we've gone with how we display other module splash screens. |
Follow-up to #5455: The actual UI for the
SetupPublicationPendingVerification
component should be implemented based on the Figma design.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
SetupPublicationPendingVerification
component should have its proper UI implemented, from this Figma design, reusing the applicable components introduced in Implement TwG setup UI for publication setup completed scenario #5525.https://publishercenter.google.com/
(opening in a new tab).Implementation Brief
In
assets/js/modules/thank-with-google/components/setup/SetupPublicationPendingVerification.js
. This component is being implemented in #5455:SetupPublicationScreen
component (which is being implemented in Implement TwG setup UI for publication setup completed scenario #5525) with the following props:title
- "Reviewing your account application"description
- "We received your request to create a Thank with Google account. Check again for updates to your status."Link
component as children with the translated copy "Check your status". It should have the following props:href
-https://publishercenter.google.com/
external
-true
ariaLabel
- "Check your status on Thank with Google Publisher Center"Test Coverage
SetupMain
component story for this scenario works as expected.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: