Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details on popup when user disconnects Thank with Google #5661

Closed
wpdarren opened this issue Aug 5, 2022 · 6 comments
Closed

Add details on popup when user disconnects Thank with Google #5661

wpdarren opened this issue Aug 5, 2022 · 6 comments
Labels
Module: Thank with Google Thank with Google module related issues P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@wpdarren
Copy link
Collaborator

wpdarren commented Aug 5, 2022

Bug Description

When a user disconnects Thank with Google a popup appears asking them to confirm the disconnection. On other modules we have a message informing the user what they will no longer have access to. To be consistent we should create a message for TwG on this popup confirmation box.

image.png

Steps to reproduce

  1. Go to Site Kit settings
  2. Click on Thank with Google
  3. Click on the 'edit', then the Disconnect Thank with Google from Site Kit link
  4. See popup box with message asking user to disconnect.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Include the following text on the disconnect popup:

  • Description: By disconnecting the Thank with Google module from Site Kit, you will no longer have access to:
  • List item 1: Virtual stickers and personal messages from your supporters
  • List item 2: Revenue from any paid virtual stickers supporters send you

Implementation Brief

In assets/js/modules/thank-with-google/index.js, within the registerModule function, add the following:

  • Add the features property to the modules.registerModule method's second parameter, which is an object.
  • The value should be an array of translated strings below:
    • Virtual stickers and personal messages from your supporters
    • Revenue from any paid virtual stickers supporters send you
  • Note: The description will already be displayed by providing the features property.

Test Coverage

  • No new tests are to be added.

QA Brief

  • Go to Site Kit settings.
  • Click on Thank with Google.
  • Click on the edit, then click on the Disconnect Thank with Google from Site Kit link.
  • Ensure the description and the list items are displayed.

Screenshot 2022-08-16 at 12 14 21 PM

Changelog entry

  • Show a list of features on the Thank with Google disconnection modal.
@wpdarren wpdarren added Module: Thank with Google Thank with Google module related issues Type: Enhancement Improvement of an existing feature labels Aug 5, 2022
@aaemnnosttv aaemnnosttv added the P0 High priority label Aug 5, 2022
@eclarke1
Copy link
Collaborator

eclarke1 commented Aug 8, 2022

@aaemnnosttv Mariya is OoO all week, could anyone else contribute to progressing this one instead?

@eclarke1
Copy link
Collaborator

@marrrmarrr as quickly as possible w/c Aug 15 when you're back, could we kindly ask you to add ACs here so we can aim to get this issue into Approval by Aug 19 ahead of bug bash. Thank you

@marrrmarrr
Copy link
Collaborator

@aaemnnosttv @eclarke1 updated! LMK if you need any more context here

@eclarke1
Copy link
Collaborator

Thanks so much @marrrmarrr I will move this over to IB now as we want to get it into Approval by Friday this week.

@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Aug 15, 2022
@hussain-t hussain-t self-assigned this Aug 16, 2022
@hussain-t hussain-t removed their assignment Aug 16, 2022
@techanvil techanvil assigned techanvil and unassigned techanvil Aug 16, 2022
@mohitwp mohitwp self-assigned this Aug 16, 2022
@mohitwp
Copy link
Collaborator

mohitwp commented Aug 17, 2022

QA Update ✅

  • Verified description and the list items are displaying under pop up confirmation box.
  • Verified font and button styles. It is matching with existing style.
  • Verified in mobile devices.

image

@mohitwp mohitwp removed their assignment Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Thank with Google Thank with Google module related issues P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

9 participants