-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details on popup when user disconnects Thank with Google #5661
Comments
@aaemnnosttv Mariya is OoO all week, could anyone else contribute to progressing this one instead? |
@marrrmarrr as quickly as possible w/c Aug 15 when you're back, could we kindly ask you to add ACs here so we can aim to get this issue into Approval by Aug 19 ahead of bug bash. Thank you |
@aaemnnosttv @eclarke1 updated! LMK if you need any more context here |
Thanks so much @marrrmarrr I will move this over to IB now as we want to get it into Approval by Friday this week. |
IB ✔️ |
Bug Description
When a user disconnects Thank with Google a popup appears asking them to confirm the disconnection. On other modules we have a message informing the user what they will no longer have access to. To be consistent we should create a message for TwG on this popup confirmation box.
Steps to reproduce
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Include the following text on the disconnect popup:
Implementation Brief
In
assets/js/modules/thank-with-google/index.js
, within theregisterModule
function, add the following:features
property to themodules.registerModule
method's second parameter, which is an object.features
property.Test Coverage
QA Brief
edit
, then click on theDisconnect Thank with Google from Site Kit
link.Changelog entry
The text was updated successfully, but these errors were encountered: